Fix waitUntil paramenter ordering; update waitUntil documentation; #3839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Status
|
vaibhavsingh97
approved these changes
Jul 27, 2023
| @@ -10,5 +10,9 @@ describe('demo tests using waitUntil element APIs', function() { | |||
| it('wait until element is enabled', function({element}) { | |||
| element('#weblogin').waitUntil('enabled'); | |||
| }); | |||
|
|
|||
| it('wait until with custom message', function({element}) { | |||
| element('#weblogin').waitUntil('enabled', {message: 'elemento %s no era presente en %d ms'}); | |||
There was a problem hiding this comment.
what does the %s and %d do here?
There was a problem hiding this comment.
The message supports two placeholders: %s for current selector and %d for the time (e.g. Element %s was not in the page for %d ms).
garg3133
approved these changes
Jul 29, 2023
AutomatedTester
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.