Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types for Nightwatch settings/config file. #3876

Merged
merged 7 commits into from
Jan 9, 2024
Merged

Fix types for Nightwatch settings/config file. #3876

merged 7 commits into from
Jan 9, 2024

Conversation

garg3133
Copy link
Member

No description provided.

@garg3133 garg3133 changed the title Fix types for Nightwatch settings. Fix types for Nightwatch exports test syntax. Aug 16, 2023
@garg3133 garg3133 changed the title Fix types for Nightwatch exports test syntax. Fix types for Nightwatch settings/config file. Aug 18, 2023
@garg3133
Copy link
Member Author

garg3133 commented Jan 8, 2024

@beatfactor I looked through this PR and this can be merged. Although we would need to revisit the desired-capabilities.d.ts and nightwatch-options.d.ts files later on to delete the fields not used/recommended anymore and fix/update the TSDoc here and there, this is good to go for now and the typings are correct to the best of my knowledge.

@beatfactor beatfactor merged commit 0d70317 into nightwatchjs:main Jan 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravityvi gravityvi gravityvi approved these changes

@beatfactor beatfactor Awaiting requested review from beatfactor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garg3133 @gravityvi @beatfactor