Migrating lib/utils/debuggability.js file to Typescript. #3880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashPratp983
changed the title
Status
|
garg3133
approved these changes
Aug 17, 2023
vaibhavsingh97
requested changes
Aug 17, 2023
There was a problem hiding this comment.
I recommend using Private Class Members features of Javascript
Ref: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Private_class_fields
lib/utils/debuggability.ts
Outdated
Comment on lines
2
to
3
| private static _debugMode: boolean; | ||
| private static _stepOverAndPause: boolean; |
There was a problem hiding this comment.
Suggested change
| private static _debugMode: boolean; | |
| private static _stepOverAndPause: boolean; | |
| static #debugMode: boolean = false; | |
| static #stepOverAndPause: boolean = false; |
There was a problem hiding this comment.
I think we should avoid changing the functionality of the code while annotating. So, while changing to # notation seems fine to me here, we should avoid initializing them with false, which will definitely impact the functionality of the transpiled JS code.
17 tasks
garg3133
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.