Add exhaustive types for waitFor commands. #3986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3981
Earlier, the typings for the waitFor commands were very restrictive due to which the formats which worked in JS were not working in TS.
This PR makes the types for the waitFor commands lenient so that everything that works in JS continues to work in TS, but at the added expense of not at all strict typings which could be error-prone for users (though the argument names have been constructed in a way to reduce this).
Other solution to this would have been to create an overload corresponding to every way the command can be used, but that would have led to way too many overloads for each waitFor command and would have been hard to manage.