Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nightwatch overwriting test status set by user. #3999

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

garg3133
Copy link
Member

Fixes: #3998

This PR does the following:

  • If the status of a test is already found to be set in BrowserStack, it does not overwrite the status.
  • Only request for builds currently running while trying to get the build id (otherwise if there are too many builds, the build used in the test run is never returned by BrowserStack, due to which the build id is set to undefined).

Copy link

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

@beatfactor beatfactor merged commit c5331d2 into nightwatchjs:main Jan 24, 2024
17 checks passed
@garg3133 garg3133 deleted the bstack-suiteRetries branch January 24, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set custom session status for retried test.
2 participants