Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added isDisplayed() as alias to isVisible() #4107

Merged

Conversation

uditrajput03
Copy link
Contributor

@uditrajput03 uditrajput03 commented Mar 8, 2024

Fixed #4105
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@CLAassistant
Copy link

CLAassistant commented Mar 8, 2024

CLA assistant check
All committers have signed the CLA.

@uditrajput03
Copy link
Contributor Author

@garg3133 would you mind reviewing my PR

@uditrajput03 uditrajput03 changed the title Added isDisplayed as alias to isVisible Added isDisplayed() as alias to isVisible() Mar 8, 2024
@uditrajput03 uditrajput03 changed the title Added isDisplayed() as alias to isVisible() Added isDisplayed() as alias to isVisible() Mar 8, 2024
@garg3133
Copy link
Member

garg3133 commented Mar 9, 2024

@uditrajput03 The PR looks good, thanks!

For tests, the top two test cases are sufficient. You can remove the rest.

@uditrajput03
Copy link
Contributor Author

@uditrajput03 The PR looks good, thanks!

For tests, the top two test cases are sufficient. You can remove the rest.

Sure, Earlier I also think that.
I have done the required changes have a look and Thanks @garg3133 for reviewing my PR.

@AutomatedTester AutomatedTester merged commit e97a90c into nightwatchjs:main Mar 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add isDisplayed() as an alias command for isVisible() in new Element API.
5 participants