oSPARC: slight improvement to check_simulation()'s logic.

nih-sparc · Nov 8, 2023 · 64b1e9b · 64b1e9b
1 parent 34db50a
commit 64b1e9b
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/app/osparc/osparc.py b/app/osparc/osparc.py
@@ -152,12 +152,10 @@ def check_simulation(data):
         solver_version = data["solver"]["version"]
         status = solvers_api.inspect_job(solver_name, solver_version, job_id)
 
-        if status.state in {"SUCCESS", "FAILED"}:
-            # The simulation has completed, but was it successful?
-
-            if status.state == "FAILED":
-                raise SimulationException("the simulation failed")
+        if status.state == "FAILED":
+            raise SimulationException("the simulation failed")
 
+        if status.state == "SUCCESS":
             # Retrieve the simulation job outputs.
 
             try: