Wrap suggestion voting permission check in a function

Signed-off-by: Michal Čihař <michal@cihar.com>

weblate/html/translate.html

@@ -8,6 +8,7 @@
 {% can_suggest user unit.translation as user_can_suggest %}
 {% can_accept_suggestion user unit.translation as user_can_accept_suggestion %}
 {% can_delete_suggestion user unit.translation as user_can_delete_suggestion %}
+{% can_vote_suggestion user unit.translation as user_can_vote_suggestion %}
 
 
 {% block extra_meta %}
@@ -180,13 +181,13 @@ <h5><strong>
 {% endif %}
 </strong></h5>
 {% format_translation suggestion.target unit.translation.language unit.target %}
-{% if unit.can_vote_suggestions %}
+{% if user_can_vote_suggestions %}
 <p class="help-block">
 {% blocktrans count count=suggestion.get_num_votes %}{{ count }} vote{% plural %}{{ count }} votes{% endblocktrans %}
 </p>
 {% endif %}
 <div class="pull-right flip">
-{% if unit.can_vote_suggestions and perms.trans.vote_suggestion %}
+{% if user_can_vote_suggestions %}
 <button type="submit" class="btn btn-success btn-xs" name="upvote" value="{{ suggestion.id }}"><i class="fa fa-thumbs-up"></i> {% trans "Vote for" %}</button>
 <button type="submit" class="btn btn-danger btn-xs" name="downvote" value="{{ suggestion.id }}"><i class="fa fa-thumbs-down"></i> {% trans "Vote against" %}</button>
 {% endif %}

weblate/trans/models/unit.py

@@ -953,12 +953,6 @@ def nearby(self):
             position__lte=self.position + appsettings.NEARBY_MESSAGES,
         ).select_related()
 
-    def can_vote_suggestions(self):
-        """
-        Whether we can vote for suggestions.
-        """
-        return self.translation.subproject.suggestion_voting
-
     def translate(self, request, new_target, new_fuzzy):
         """
         Stores new translation of a unit.

weblate/trans/models/unitdata.py

@@ -24,6 +24,7 @@
 from weblate.lang.models import Language
 from weblate.trans.checks import CHECKS
 from weblate.trans.models.changes import Change
+from weblate.trans.permissions import can_vote_suggestion
 from weblate.accounts.avatar import get_user_display
 from weblate.accounts.models import notify_new_suggestion, notify_new_comment
 
@@ -60,7 +61,7 @@ def add(self, unit, target, request):
         )
 
         # Add unit vote
-        if user is not None and unit.can_vote_suggestions():
+        if can_vote_suggestion(user, unit.translation):
             suggestion.add_vote(
                 unit.translation,
                 request,

weblate/trans/permissions.py

@@ -73,3 +73,20 @@ def can_delete_suggestion(user, translation):
     Checks whether user can delete suggestions to given translation.
     """
     return can_edit(user, translation, 'trans.delete_suggestion')
+
+
+def can_vote_suggestions(user, translation):
+    """
+    Checks whether user can vote suggestions on given translation.
+    """
+    if translation is None or user is None:
+        return False
+    if not translation.subproject.suggestion_voting:
+        return False
+    if translation.subproject.locked:
+        return False
+    if not user.has_perm('trans.vote_suggestion'):
+        return False
+    if translation.is_template() and not user.has_perm('trans.save_template'):
+        return False
+    return True

weblate/trans/templatetags/permissions.py

@@ -49,3 +49,10 @@ def can_delete_suggestion(user, translation):
     return weblate.trans.permissions.can_delete_suggestion(
         user, translation
     )
+
+
+@register.assignment_tag
+def can_vote_suggestion(user, translation):
+    return weblate.trans.permissions.can_vote_suggestion(
+        user, translation
+    )