Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode/Utf8 filenames #5

Closed
wants to merge 1 commit into from
Closed

Unicode/Utf8 filenames #5

wants to merge 1 commit into from

Conversation

dekz
Copy link
Contributor

@dekz dekz commented Sep 17, 2011

Support utf8value file names which is also compatible with ascii.

Fixed:

sagan dekz$ node node_modules/taglib/examples/simple.js ~/Projects/node-taglib/examples/ここには何もかもがあるし、何もかもがない.mp3 
TagLib: Could not open file /Users/dekz/Projects/node-taglib/examples/SSkoU?K?K?B?WU?K?K?jD.mp3

node.js:189
        throw e; // process.nextTick error, or 'error' event on first tick
        ^
Error while reading data from /Users/dekz/Projects/node-taglib/examples/SSkoU?K?K?B?WU?K?K?jD.mp3

Reading in the data is fine though:

DEBUG: { genre: '',
  artist: 'Toe',
  album: 'For Long Tomorrow',
  year: 2009,
  title: 'ここには何もかもがあるし、何もかもがない',
  track: 1 }

@nikhilm
Copy link
Owner

nikhilm commented Oct 3, 2011

This has been merged - 57fb80c
Thanks a lot!

@nikhilm nikhilm closed this Oct 3, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants