Handle attribute 'is_secure' better while flattening PluginConfiguration

nikhilsbhat · Dec 30, 2022 · 56b965b · 56b965b
1 parent c67b936
commit 56b965b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 13 deletions.
diff --git a/examples/yaml_plugins_setttings.tf b/examples/yaml_plugins_setttings.tf
@@ -1,11 +1,11 @@
-resource "gocd_plugin_setting" "yaml_plugin_settings" {
-  plugin_id = "yaml.config.plugin"
-  plugin_configurations {
-    key   = "file_pattern"
-    value = "*.gocd.yaml"
-  }
-  plugin_configurations {
-    key   = "file_pattern"
-    value = "*.gocd.yam"
-  }
-}
+//resource "gocd_plugin_setting" "yaml_plugin_settings" {
+//  plugin_id = "yaml.config.plugin"
+//  plugin_configurations {
+//    key   = "file_pattern"
+//    value = "*.gocd.yaml"
+//  }
+//  plugin_configurations {
+//    key   = "file_pattern"
+//    value = "*.gocd.yam"
+//  }
+//}
diff --git a/gocd/resource_plugin_settings.go b/gocd/resource_plugin_settings.go
@@ -182,14 +182,16 @@ func resourcePluginsSettingsDelete(ctx context.Context, d *schema.ResourceData,
 
 func getPluginConfiguration(configs interface{}) []gocd.PluginConfiguration {
 	pluginsConfigurations := make([]gocd.PluginConfiguration, 0)
-	for _, config := range configs.(*schema.Set).List() {
+	for i, config := range configs.(*schema.Set).List() {
 		v := config.(map[string]interface{})
 		pluginsConfigurations = append(pluginsConfigurations, gocd.PluginConfiguration{
 			Key:            utils.String(v[utils.TerraformResourceKey]),
 			Value:          utils.String(v[utils.TerraformResourceValue]),
 			EncryptedValue: utils.String(v[utils.TerraformResourceENCValue]),
-			IsSecure:       utils.Bool(v[utils.TerraformResourceIsSecure]),
 		})
+		if isSecure, ok := v[utils.TerraformResourceIsSecure]; ok {
+			pluginsConfigurations[i].IsSecure = utils.Bool(isSecure)
+		}
 	}
 
 	return pluginsConfigurations