Fix backgroundColor option documentation (Fix #1164)

niklasvh · Dec 12, 2017 · 3965a0f · 3965a0f
1 parent 77d258f
commit 3965a0f
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/docs/configuration.md b/docs/configuration.md
@@ -13,7 +13,7 @@ These are all of the available configuration options.
 | ------------- | :------: | ----------- |
 | async | `true` | Whether to parse and render the element asynchronously
 | allowTaint | `false` | Whether to allow cross-origin images to taint the canvas
-| backgroundColor | `#ffffff` | Canvas background color, if none is specified in DOM. Set undefined for transparent
+| backgroundColor | `#ffffff` | Canvas background color, if none is specified in DOM. Set `null` for transparent
 | canvas | `null` | Existing `canvas` element to use as a base for drawing on
 | foreignObjectRendering | `false` | Whether to use ForeignObject rendering if the browser supports it
 | imageTimeout | `15000` | Timeout for loading an image (in milliseconds). Set to `0` to disable timeout.

diff --git a/package-lock.json b/package-lock.json
diff --git a/src/Renderer.js b/src/Renderer.js
@@ -353,8 +353,8 @@ export default class Renderer {
     render(stack: StackingContext): Promise<*> {
         if (this.options.backgroundColor) {
             this.target.rectangle(
-                0,
-                0,
+                this.options.x,
+                this.options.y,
                 this.options.width,
                 this.options.height,
                 this.options.backgroundColor

diff --git a/src/index.js b/src/index.js
@@ -64,6 +64,7 @@ const html2canvas = (element: HTMLElement, conf: ?Options): Promise<*> => {
     const defaultOptions = {
         async: true,
         allowTaint: false,
+        backgroundColor: '#ffffff',
         imageTimeout: 15000,
         logging: true,
         proxy: null,