add features for border-style dashed, dotted, double. #2531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes/implements the following bugs/features
XxxXxxPaddingBox
correctly inbound-curves.ts
XxxXxxBorderStroke
inbound-curves.ts
XxxXxxBorderDoubleOuterBox
andXxxXxxBorderDoubleInnerBox
Test plan (required)
Dashed (browser, tests/reftests/border/dashed.html)
![image](https://user-images.githubusercontent.com/1835204/118420682-72db8380-b6fa-11eb-963c-778f03e0947a.png)
Dashed (html2canvas, tests/reftests/border/dashed.html)
![image](https://user-images.githubusercontent.com/1835204/118420694-7bcc5500-b6fa-11eb-9522-7e075797e8ca.png)
Dotted (browser, tests/reftests/border/dotted.html)
![image](https://user-images.githubusercontent.com/1835204/118420762-a3232200-b6fa-11eb-8825-0986a09543ec.png)
Dotted (html2canvas, tests/reftests/border/dotted.html)
![image](https://user-images.githubusercontent.com/1835204/118420783-ad452080-b6fa-11eb-8ce1-6aa9072bc1e9.png)
Double (browser, tests/reftests/border/double.html)
![image](https://user-images.githubusercontent.com/1835204/118420848-c3eb7780-b6fa-11eb-8ecf-fa41272b8e16.png)
Double (html2canvas, tests/reftests/border/double.html)
![image](https://user-images.githubusercontent.com/1835204/118420899-d796de00-b6fa-11eb-84a3-5810c665cae2.png)
Radius (browser, tests/reftests/border/radius.html)
![image](https://user-images.githubusercontent.com/1835204/118420962-090fa980-b6fb-11eb-8009-cbd1be713f88.png)
Radius (html2canvas this branch, tests/reftests/border/radius.html)
![image](https://user-images.githubusercontent.com/1835204/118421004-1f1d6a00-b6fb-11eb-9ed9-3d1d47ec4903.png)
Radius (html2canvas 1.0.0-rc.7, tests/reftests/border/radius.html)
![image](https://user-images.githubusercontent.com/1835204/118421191-981cc180-b6fb-11eb-9e2d-52790fa0b5b4.png)
Closing issues
Fixes #210, Fixes #366, Fixes #1354