Updated version of support for checkboxes and radio buttons #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed IndexSizeError in IE when the size of the image exceedes 8192 pixels
…e-fix Large border radius chrome fix
update copyright year
|
This now also includes a small fix for the way pseudo elements are matched: the regex was too simple for complex CSS expressions. |
added 2 commits
July 4, 2014 16:36
…nts. The selector was created by taking the string just up until the first colon, but that's incorrect in the case of other pseudoclasses like :checked, or in the case of complex rules that involve multiple selectors like "foo:before, bar:before". The way we do it now is to remove the :after/:before string we're looking for using the same regex that tests for it. This got broken in commit 8bea01b (the original code appears to simply have used the parentNode)
…hey have a presence in the DOM even if their text value is empty
|
Implemented in 0.5 893ce74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simply a port of #159 to the latest master. I've also updated the files under build/, as they're outdated (which means people using bower or npm to download html2canvas get to see an old version)