Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render element regardless of its position on the page #88

Closed
wants to merge 3 commits into from

Conversation

OneGeek
Copy link

@OneGeek OneGeek commented Apr 3, 2012

Added options.renderRootAtOrigin flag, when set to true the element being rendered will be rendered at 0,0 instead of at its actual page position. However, as it is now the resulting image will be the full page's dimensions instead of the target element's.

Haven't yet figured out exactly where the final image size is determined, so the resulting image needs to be cropped. Not sure what will happen if the element to be rendered is taller than whatever size is currently chosen for the image.

…eing rendered will be rendered at 0,0 instead of at its actual page position. However, as it is now the resulting image will be the full page's dimensions instead of the target element's.
@OneGeek
Copy link
Author

OneGeek commented Apr 3, 2012

Darn, screwed something up, working on fixing it.

@OneGeek
Copy link
Author

OneGeek commented Apr 3, 2012

Nevermind, it works fine, I had stopped including jquery by mistake

@niklasvh
Copy link
Owner

Thanks for the pull request. However, I am bit confused as to how this is different from using a specific element to render as in 0cb252a / http://html2canvas.hertzen.com/tests/origin.html ?

@OneGeek
Copy link
Author

OneGeek commented Apr 13, 2012

Hmm, when I tried to render a single element only as much as was visible on
the page itself would be rendered, and that would get stretched to the size
of the whole widget, I'll look into this more to see if I was doing it
wrong.

On Thu, Apr 12, 2012 at 3:59 PM, Niklas von Hertzen <
reply@reply.github.com

wrote:

Thanks for the pull request. However, I am bit confused as to how this is
different from using a specific element to render as in
https://github.com/niklasvh/html2canvas/commit/0cb252ada91c84ef411288b317c03e97da1f12ad/
http://html2canvas.hertzen.com/tests/origin.html ?


Reply to this email directly or view it on GitHub:
#88 (comment)

@niklasvh niklasvh closed this Jan 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants