7 http client di (#8)

* #7 - Changed DI for the http client * #7 - Changed location of base URL for the client --------- Co-authored-by: Eduard Keilholz <e.keilholz@4dotnet.nl>
nikneem · May 6, 2024 · 27a83d8 · 27a83d8
1 parent c335552
commit 27a83d8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 12 deletions.
diff --git a/src/Sessionize.Api.Client/DependencyInjection/ServiceCollectionExtensions.cs b/src/Sessionize.Api.Client/DependencyInjection/ServiceCollectionExtensions.cs
@@ -26,11 +26,7 @@ public static IServiceCollection AddSessionizeApiClient(this IServiceCollection
             throw new SessionizeApiClientException(ErrorCode.InvalidConfiguration);
         }
 
-        services.AddHttpClient(SessionizeConstants.HttpClientName, client =>
-            {
-                client.BaseAddress = new Uri(sessionizeConfiguration.BaseUrl);
-                client.Timeout = TimeSpan.FromSeconds(10);
-            })
+        services.AddHttpClient<SessionizeApiClient>()
             .AddStandardResilienceHandler();
 
         services.AddScoped<ISessionizeApiClient, SessionizeApiClient>();

diff --git a/src/Sessionize.Api.Client/SessionizeApiClient.cs b/src/Sessionize.Api.Client/SessionizeApiClient.cs
@@ -54,7 +54,8 @@ public Task<List<SpeakerWallDto>> GetSpeakerWallAsync()
 
     private async Task<TResult> SendRequestAsync<TResult>(string endpoint)
     {
-        var httpClient = _httpClientFactory.CreateClient(SessionizeConstants.HttpClientName);
+        var httpClient = _httpClientFactory.CreateClient();
+        httpClient.BaseAddress = new Uri(_sessionizeConfiguration.Value.BaseUrl);
         _logger.LogInformation("Sending GET request to endpoint {Endpoint}", GetViewEndpoint(endpoint));
         var response = await httpClient.SendAsync(GetRequest(endpoint));
         response.EnsureSuccessStatusCode();

diff --git a/src/Sessionize.Api.Client/SessionizeConstants.cs b/src/Sessionize.Api.Client/SessionizeConstants.cs