Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Added msgerrors package and refactored code for safer error handling #22

Closed

Conversation

KrishanBhalla
Copy link
Contributor

@KrishanBhalla KrishanBhalla commented Feb 2, 2021

Info

References #21
Attempts to limit service failure if a receivers are invalid.

Proposed changes

  1. Add msgerrors package
  2. Added unit tests for msgerrors
  3. Collate errors within (notifier).Send, and return a new error after attempting to send to all recievers
  4. Refactor of all relevant services to support this

Note

This is a proposed change that may require some iteration.
Question: msgerrors package name / function names - is there something clearer we should use instead?

Tested the Slack, Pushbullet, and PushbulletSMS services locally - all seems fine.

@nikoksr
Copy link
Owner

nikoksr commented Feb 23, 2021

Closing this because of this comment.

@nikoksr nikoksr closed this Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants