-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(service): add twilio #276
Conversation
07fd023
to
7a32777
Compare
Codecov Report
@@ Coverage Diff @@
## main #276 +/- ##
==========================================
+ Coverage 54.62% 55.44% +0.81%
==========================================
Files 14 16 +2
Lines 540 588 +48
==========================================
+ Hits 295 326 +31
- Misses 222 235 +13
- Partials 23 27 +4
Continue to review full report at Codecov.
|
7a32777
to
d1a6f74
Compare
d1a6f74
to
b926651
Compare
b926651
to
2879767
Compare
Why is this not accepted @nikoksr ? |
@svaloumas so sorry for the severe delay! I fixed all compatibility issues with main and it looks like we're read to merge. Since I updated this branche's go.mod, I'd be very thankful if you could quickly verify that the Twillio service you wrote is actually still working with the latest changes. I greatly appreciate your patience and effort! |
Hey @nikoksr, no worries at all! I've just tested it once again after pulling your changes and it's still functional. 😄 |
Description
Adds Twilio (Messaging) service.
Resolves #115
Motivation and Context
Adds a new service to the list of the currently supported ones.
How Has This Been Tested?
Unit tests implemented under
service/twilio/twilio_test.go
.Integration tests have been performed using a trial account from Twilio Console.
Sample code to run an integration test.
Please find below sample images from the results of the integration tests.
Screenshots / Output (if appropriate):
Types of changes
Checklist: