feat(service): add lark service #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikoksr
reviewed
Aug 4, 2022
Comment on lines
+52
to
+58
| const ( | ||
| openID receiverIDType = "open_id" | ||
| userID receiverIDType = "user_id" | ||
| unionID receiverIDType = "union_id" | ||
| email receiverIDType = "email" | ||
| chatID receiverIDType = "chat_id" | ||
| ) |
There was a problem hiding this comment.
I added the receiverIDType to all constants due to this. Could you please verify that this does not break functionality and/or behavior?
There was a problem hiding this comment.
Tested it again manually and still works fine!
|
@immanuelhume so sorry for the very late response. I fixed the compatibility issues with the main branch and some linter warnings. Please check those before you push next time, please. I greatly appreciate your patience and contribution! |
|
@nikoksr Sorry I must've missed those warnings. Thanks for maintaining this project! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a notifier service for Lark.
Motivation and Context
This addresses #268.
Lark has three kinds of bots, referred to as "webhook", "custom app", and "store app" bots. The first two are supported through this PR, which explains the two different files
webhook.goandcustom_app.go. The store apps have a tricky API which would work against the simple style of this library so they are not included here.How Has This Been Tested?
Basic unit tests using mocks have been written. Manual testing has also been performed.
Screenshots / Output (if appropriate):
The first screenshot is with a webhook. The second is with a custom app.
Types of changes
Checklist: