build/fix buildtools #343
Merged
build/fix buildtools #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add setup command to make installing of dependencies explicit.
WaitForOneOffVerification now uses a ReadHeaderTimeout of 20 seconds by default. This is to avoid potential slow loris attacks which means blocking a connection for too long. In case that the user wants to provide a custom timeout, I added the WaitForOneOffVerificationWithServer method. It works identical to WaitForOneOffVerification with the subtle difference that the user can pass in a fully customized http.Server instance. This closes gosec G112.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Slight cleanup of the repo, fixed linter errors and buildtool problems.
Also updated go module from v1.17 to 1.19.
Motivation and Context
Automatic PRs were broken due to linter issues.
How Has This Been Tested?
Ran 'make test' and used the library in a separate project. Messages were sent
out successfully.
Screenshots / Output (if appropriate):
Types of changes
Checklist: