Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): export types that are being returned by some methods #374

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

nikoksr
Copy link
Owner

@nikoksr nikoksr commented Aug 31, 2022

Description

The revive linter complained about certain types that were not exported but being used as return values by certain methods. I exported these types now and added the missing comments for them.

Motivation and Context

GitHub pipeline was stuck due to the linter complaining about this issue.

How Has This Been Tested?

Ran the linter and test suit locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Base: 55.91% // Head: 55.91% // No change to project coverage 👍

Coverage data is based on head (df3fb4c) compared to base (e1df177).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #374   +/-   ##
=======================================
  Coverage   55.91%   55.91%           
=======================================
  Files          21       21           
  Lines         719      719           
=======================================
  Hits          402      402           
  Misses        286      286           
  Partials       31       31           
Impacted Files Coverage Δ
service/lark/common.go 100.00% <100.00%> (ø)
service/lark/custom_app.go 53.44% <100.00%> (ø)
service/lark/webhook.go 39.13% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nikoksr
Copy link
Owner Author

nikoksr commented Aug 31, 2022

@svaloumas fyi, I just noticed that the PR pipeline is stuck. Found it kinda weird that there are seven open PRs.

On further inspection it appeared that the auto-merge didn't get green light due to the linter failing. Explanation is up above. Not too sure how this didn't happen earlier tbh. Anyways, this should fix it. Just wanted to quickly update you on this, too.

@nikoksr nikoksr merged commit 8023248 into main Aug 31, 2022
@nikoksr nikoksr deleted the fix/linter-complains branch August 31, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants