Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(nightly): explicitly remove previous nightly release #387

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

nikoksr
Copy link
Owner

@nikoksr nikoksr commented Sep 11, 2022

Description

Explicitly remove the previous nightly release before creating the new one.

Motivation and Context

I expected the action that creates the nightly release to also remove the old release. It has options for keeping old releases etc but appararently it's none of its business. Thus, we're now explicitly removing the 'nightly' tag before re-creating it.

How Has This Been Tested?

Ran act locally and it successfully removed the old tag and created the new release, all in remote.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other CI

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • [ x All new and existing tests passed.

I expected the action that creates the nightly release to also remove
the old release. It has options for keeping old releases etc but
appararently it's none of its business. Thus, we're now explicitly
removing the 'nightly' tag before re-creating it.
@codecov-commenter
Copy link

Codecov Report

Base: 55.91% // Head: 55.91% // No change to project coverage 👍

Coverage data is based on head (1f5c955) compared to base (5652317).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #387   +/-   ##
=======================================
  Coverage   55.91%   55.91%           
=======================================
  Files          21       21           
  Lines         719      719           
=======================================
  Hits          402      402           
  Misses        286      286           
  Partials       31       31           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nikoksr
Copy link
Owner Author

nikoksr commented Sep 11, 2022

@svaloumas this should fix the auto-deploy of the nightly-release. However, I'm still not sure why the action was not fired off at exactly 0:00 am UTC to be honest. Seems to be pretty straight forward to me, when you look at the action file. We'll have to keep an eye on that.

@nikoksr nikoksr merged commit 2d65ca3 into main Sep 11, 2022
@nikoksr nikoksr deleted the ci/fix-nightly-release branch September 11, 2022 10:16
@nikoksr nikoksr restored the ci/fix-nightly-release branch September 12, 2022 11:13
@nikoksr nikoksr deleted the ci/fix-nightly-release branch September 12, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants