Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sec(codeql): fix potential cross-site scripting vulnerability #427

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

nikoksr
Copy link
Owner

@nikoksr nikoksr commented Oct 19, 2022

Description

Escape user input to prevent potential cross-site scripting attack.

Motivation and Context

CodeQL security alerts #1 and #2.

How Has This Been Tested?

Ran tests locally.

Screenshots / Output (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Base: 64.34% // Head: 64.34% // No change to project coverage 👍

Coverage data is based on head (e9dd1a8) compared to base (93a1552).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #427   +/-   ##
=======================================
  Coverage   64.34%   64.34%           
=======================================
  Files          32       32           
  Lines        1091     1091           
=======================================
  Hits          702      702           
  Misses        324      324           
  Partials       65       65           
Impacted Files Coverage Δ
service/wechat/wechat.go 34.56% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nikoksr
Copy link
Owner Author

nikoksr commented Oct 19, 2022

@svaloumas adding you for the required review. Not that it's really necessary 😆

@nikoksr nikoksr merged commit ce792a2 into main Oct 19, 2022
@nikoksr nikoksr deleted the sec/fix-cross-site-scripting branch October 19, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants