refactor(send): Add context.Context to parameter list of Send method #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikoksr
changed the title
nikoksr
changed the title
|
@checkaayush could you give this a quick review? |
checkaayush
approved these changes
Feb 23, 2021
nikoksr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
This closes #49. I added context.Context to the parameter list to all implementations and definitions of the Send method. This will allow users to cancel long running calls of said function.
Suggested changes
Additional context
I need feedback for this! I added some TODO comments here and there.In some cases the external library does not accept a context.Context itself and we don't loop over receivers but pass them all at once. This makes it hard for me to decide how to handle the context correctly. Do we check context.Context.IsDone at the beginning of a Send implementation, do we check it right before actually sending the message payload to the external service?