Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Allow Inversion of Colour scheme #10

Closed
jammiemil opened this issue Oct 12, 2022 · 3 comments
Closed

Feature Request: Allow Inversion of Colour scheme #10

jammiemil opened this issue Oct 12, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@jammiemil
Copy link

Thanks for the new panel, this is one of the tidier comparison plugins I've seen :)

One thing that would be nice to have would be to be able to invert the red/green + up/down relationship for values where and increase is bad rather than good.

For example in the below image i would want the default behaviour for 'Allowed' as an increased in Allowed items is Good, but an increase in Blocked items is bad so i would like the comparison to be red in the right hand panel:

image
@jammiemil jammiemil changed the title Feature Request: Allow Inversation of Color scheme Feature Request: Allow Inversion of Colour scheme Oct 12, 2022
@nikos
Copy link
Owner

nikos commented Oct 12, 2022

Thanks for the kind words and great suggestion. Will have a look at it next week (currently on vacation), or you might want to open an PR?

@nikos nikos added the enhancement New feature or request label Oct 12, 2022
@jammiemil
Copy link
Author

I considered it but i have zero typescript experience and I'm still recovering from giving myself a crash course in golang....

nikos added a commit that referenced this issue Oct 19, 2022
@nikos
Allow to invert colorization of trend, implement #10
2707f03
nikos added a commit that referenced this issue Oct 19, 2022
@nikos
Allow to invert colorization of trend, implement #10
1196704
@nikos
Copy link
Owner

nikos commented Oct 19, 2022

Implemented as part of 1.0.5 release

@nikos nikos closed this as completed Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikos @jammiemil