-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] test examples to replace ADHD with MAIN datasets #1887
Closed
Closed
Changes from all commits
Commits
Show all changes
130 commits
Select commit
Hold shift + click to select a range
55e253a
Merge branch 'master' of https://github.com/nilearn/nilearn
kchawla-pi f8d7c55
New OrthoSlicer Class
setina42 2ede117
Added two tests for display class TiledSlicer
setina42 50dc979
added example
setina42 e26a66d
If dtype!=None then information in the header gets deleted in functio…
wiheto 68385f5
Add call to update header's dtype
wiheto d49290b
Added a DeprecationWarning for Python 3.4
kchawla-pi 18b3a93
Added tests for DeprecationWarnings for Python 3.4; increased CircleC…
kchawla-pi bf720bd
Merge branch 'master' of https://github.com/nilearn/nilearn
kchawla-pi e52b5d6
adressing requested changes
setina42 bb2a460
improved docstring and formatting
setina42 3887e83
fixed issue: not all cuts displayed
setina42 c8ac52b
added option 'display_mode = tiled' to docstring of plotting functions
setina42 70ee303
[WIP] test examples to replace ADHD with MAIN datasets
KamalakerDadi 948ab37
tests in AppVeyor
KamalakerDadi 7f0659c
Changed fetch_adhd to main functional datasets in all examples
KamalakerDadi 9f7b14b
DOC: fix pattern not found in masker_objects.rst
KamalakerDadi 43feabb
DOC: Added in modules reference.rst
KamalakerDadi fb9dd79
DOC: Fix title underline too short issue
KamalakerDadi b625164
added demo for TiledSlicer
setina42 404ef2b
additional tests for TiledSlicer
setina42 64b4102
changes requested
setina42 b5493e5
FIX: Calculate image data dtype from header information
effigies 6163d1c
TEST: Verify quality of data type prediction
effigies 2777225
FIX: Accommodate pre-2.2 nibabel
effigies 6f66400
Empty commit to bump Travis
effigies 14fea6e
Empty commit to bump Travis
effigies 22b9030
fixed various style issues
setina42 5c757cb
added display-mode 'tiled' in a new release section 0.5.1
setina42 9cc694e
FIX: Fix abc import
larsoner a427e74
additional test and changed function names
setina42 6a61083
allow array-like marker size in view_connectome and view_markers
jeromedockes b841c90
Merge pull request #1898 from larsoner/abc
GaelVaroquaux 3027854
update doc on view_connectome
jeromedockes 93bed9c
use Template.safe_substitute instead of str.replace
jeromedockes 927b9b8
Merge branch 'master' of https://github.com/nilearn/nilearn
kchawla-pi 5cb52e1
Addressed design deficiencies in python deprecaton functions & their …
kchawla-pi a6145af
Merge of branch 'master'
kchawla-pi d10d4cd
Added tests for python deprecation warning functionality & warning fi…
kchawla-pi 16f2df2
FIX: empty contours which are lying below certain threshold with fill…
KamalakerDadi acead8d
Fixed, simplified tests for python deprecation warnings
kchawla-pi 3a6e5e8
Test file is added in test and changes performed in NiftiSpheresMasker
geekypathak21 f62d19a
Some changes required for pep8
geekypathak21 89e23bf
Added bug & feature request issue templates
kchawla-pi 70063fa
Added test to test_nifti_spheres_masker.py
geekypathak21 ffb7da8
Error message changed
geekypathak21 232e63d
A spell mistake
geekypathak21 ad87234
additional tests
setina42 b2c1b7b
acessing keys of dict: change try/pass to if-statements
setina42 910cfcc
Improved the language of the hidden message for bugs & issues
kchawla-pi d393460
PR #1908: Issue Templates for Bugs & features, redirecting usage ques…
kchawla-pi 200dc6d
Added info about utility of tagging Neurostars posts
kchawla-pi 56cfb2c
PR #1910: Added info about utility of tagging Neurostars posts
kchawla-pi b769195
Some changes for travis-CI
geekypathak21 f65564a
Comment removed from NiftiSpheresMasker.py
geekypathak21 bbdee4b
PR #1882: Improve Python Warning code & add a DeprecationWarning for …
kchawla-pi 20016f0
slight change to cover colorbar code
setina42 bd46095
PR #1869 2x2 Volumetric Plot Arrangement
kchawla-pi 147b269
PR #1906 : Fixed: NiftiSpheresMasker silently ignores voxels (Masker …
kchawla-pi bb247f2
restore lighting params to plotly defaults
jeromedockes 5bf6add
comment
jeromedockes 6dca798
Merge remote-tracking branch 'upstream/master' into lighting_surf_plot
jeromedockes cac99d9
Merge remote-tracking branch 'upstream/master' into fix/dtype_detection
effigies bb0f9ab
DOC: Add a whats_new entry
effigies 6854ce9
update whatsnew
jeromedockes caf7496
PR #1892 FIX Calculate image data dtype from header information
kchawla-pi 0ff7463
Merge remote-tracking branch 'upstream/master' into view_connectome_m…
jeromedockes 9152bc1
detail
jeromedockes bd2b538
Merge remote-tracking branch 'upstream/master' into lighting_surf_plot
jeromedockes ed86f29
PR #1901 Use Template.safe_substitute instead of str.replace
kchawla-pi af80d96
Merge pull request #1912 from jeromedockes/lighting_surf_plot
GaelVaroquaux 0e17bbe
Deprecated view_connectome params that differed from params of plot_c…
kchawla-pi 63f7a55
adding check to see if header is present
wiheto b9e15b9
adding header=None to MNI152Template
wiheto 7c878da
reoridering if statement
wiheto 8ce1b2c
Remove temporary variable imgs_ from memory
nagaflokhu aaae228
Replaced FutureWarning with DeprecationWarning, added docstrings
kchawla-pi 0d493db
Fixed: Parameter DeprecationWarnings are not displayed
kchawla-pi b963fec
Add comment explaining del imgs_ statement
nagaflokhu a9c3151
fix: quote iframe attributes
emdupre 0aed9e6
tst: update tests for quoted iframe attributes
emdupre 9973b35
Merge pull request #1914 from nagaflokhu/reduce-mem-consumption
bthirion 7d21850
Merge pull request #1916 from emdupre/fix/quote-attributes
GaelVaroquaux 9f34cda
whats_new.rst update - transform_single_imgs
nagaflokhu 11d00ca
Fixed: Parameter DeprecationWarnings are not displayed
kchawla-pi 960a4b9
Warning specifies version of Nilearn when deprecated parameters will …
kchawla-pi 16b4cdf
Adding comment about changes.
wiheto 8a390f3
Merge pull request #1872 from wiheto/load_niimg-addcopyheader
GaelVaroquaux 25446a0
Fixed test string for parameter deprecation test
kchawla-pi e019da4
Warning and test text now match
kchawla-pi 38d3b86
Fix failing tests & updated whats new regarding parameter name changes
kchawla-pi 3fa38ef
Improve what's new entry
nagaflokhu ef17d3f
Fix failing tests (message string not matching due to space character)
kchawla-pi e82c4fb
Merge pull request #1917 from nagaflokhu/whatsnew-update
GaelVaroquaux 4f5dbdd
Fixed: Typo in docstring spcific to specific
kchawla-pi 525c0c6
view_marker() parameters consistent with add_markers() + DeprecationW…
kchawla-pi 014f0e3
Removed unnecessary dict.keys() in set operations for keys present
kchawla-pi 10462aa
Added tests for deprecation of certain parameters of view_markers()
kchawla-pi 66e9e08
Changed default colormap for view_connectome() to same as plot_connec…
kchawla-pi 7875d23
Updated What's New regarding change in default colormap for view_conn…
kchawla-pi ef71aef
Default marker color for view_connectome() is now 'red'; Updated What…
kchawla-pi a06d638
Added test when all kwargs are used, none of them deprecated
kchawla-pi 25e85ef
PR #1913 Make parameters in view_connectome() consistent with plot_co…
kchawla-pi 562d611
Merge 'master' (post PR #1913 merge); reverted to relative import
kchawla-pi b06ee76
Reverted absolute import to relative import (Change unrelated to PR p…
kchawla-pi 60ee1cd
Merge remote-tracking branch 'upstream/master' into view_connectome_m…
jeromedockes 035e7a5
PR #1918: make view_markers() parameters consistent with add_markers()
kchawla-pi ae99ff9
Fixed: Truthiness of colors is no longer ambiguous during comparision
kchawla-pi 9ba37a0
Merge remote-tracking branch 'upstream/master' into view_connectome_m…
jeromedockes 553b904
PR #1920: Truthiness of colors is no longer ambiguous during conditio…
kchawla-pi 8363210
Update html_stat_map.py
pbellec 55259cc
Merge pull request #1924 from pbellec/patch-2
GaelVaroquaux 9ca7da7
Merge remote-tracking branch 'upstream/master' into view_connectome_m…
jeromedockes 415c9b7
marker size in pixels in view_connectome docstring
jeromedockes c5e3564
update whatsnew
jeromedockes 46816f2
Proper citation for Brainomics/Localizer dataset
DimitriPapadopoulos b60edb5
PR #1899 allow array-like marker_size in view_connectome and view_mar…
kchawla-pi 848cf15
Merge pull request #1927 from DimitriPapadopoulos/brainomics_localizer
GaelVaroquaux e1a8cd2
[WIP] test examples to replace ADHD with MAIN datasets
KamalakerDadi 0cb7993
tests in AppVeyor
KamalakerDadi cfdadaf
Changed fetch_adhd to main functional datasets in all examples
KamalakerDadi c2da2c9
DOC: fix pattern not found in masker_objects.rst
KamalakerDadi 71f92d9
DOC: Added in modules reference.rst
KamalakerDadi ca41b40
DOC: Fix title underline too short issue
KamalakerDadi 6686e2c
FIX: empty contours which are lying below certain threshold with fill…
KamalakerDadi b1d2007
[fix] update MAIN fetcher for new OSF filenames
emdupre ec407a3
[temp] fake sub63
emdupre b5aab12
Merge pull request #9 from emdupre/fix/update-osf
KamalakerDadi 4eccb80
confl
KamalakerDadi 1025c84
confl mess
KamalakerDadi File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
--- | ||
name: Bug report | ||
about: Something not working as described? Missing/incorrect documentation? This is the place. | ||
title: '' | ||
labels: 'bug' | ||
assignees: '' | ||
|
||
--- | ||
<!-- | ||
|
||
Hi! | ||
If you have: | ||
-1 Questions about how to use Nilearn or | ||
-2 Need analysis suggestions & recommendations? | ||
|
||
A bunch of fMRI researchers hang out at Neurostars (http://neurostars.org/). | ||
Post those questions there. | ||
Add the tag `nilearn` (we get an email from Neurostars if you do). | ||
|
||
Posting them here makes life more complicated for the Nilearn developers. | ||
--> | ||
|
||
<!-- | ||
|
||
For the Bug Report, | ||
Include this information: | ||
------------------------- | ||
What version of Nilearn are you using? | ||
What were you trying to do? | ||
What did you expect will happen? | ||
What actually happened? | ||
|
||
List the steps you performed that revealed the bug to you. | ||
Include any code samples. Enclose them in triple back-ticks (```) | ||
Like this: | ||
|
||
``` | ||
<code> | ||
``` | ||
--> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
--- | ||
name: Feature request | ||
about: Got an idea for a new feature, or changing an existing one? This is the place. | ||
title: '' | ||
labels: 'feature' | ||
assignees: '' | ||
|
||
--- | ||
<!-- | ||
Hi! | ||
If you have: | ||
-1 Questions about how to use Nilearn or | ||
-2 Need analysis suggestions & recommendations? | ||
|
||
A bunch of fMRI researchers hang out at Neurostars (http://neurostars.org/). | ||
Post those questions there. | ||
Add the tag `nilearn` (we get an email from Neurostars if you do). | ||
|
||
Posting them here makes life more complicated for the Nilearn developers. | ||
--> | ||
|
||
<!-- | ||
For the Feature Request, | ||
Include the following: | ||
------------------------ | ||
What would you like changed/added and why? | ||
What would be the benefit? Does the change make something easier to use? | ||
Clarifies something? | ||
If it is a new feature, what is the benefit? | ||
--> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
to extract spatially constrained brain regions from whole brain maps decomposed | ||
using dictionary learning and use them to build a functional connectome. | ||
|
||
We used 20 resting state ADHD functional datasets from :func:`nilearn.datasets.fetch_adhd` | ||
We used 20 resting state MAIN functional datasets from :func:`nilearn.datasets.fetch_main` | ||
and :class:`nilearn.decomposition.DictLearning` for set of brain atlas maps. | ||
|
||
This example can also be inspired to apply the same steps to even regions extraction | ||
|
@@ -32,9 +32,9 @@ | |
# We use nilearn's datasets downloading utilities | ||
from nilearn import datasets | ||
|
||
adhd_dataset = datasets.fetch_adhd(n_subjects=20) | ||
func_filenames = adhd_dataset.func | ||
confounds = adhd_dataset.confounds | ||
main_dataset = datasets.fetch_main(n_subjects=20) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. On this example, I think that we could increase the number of components from 5 to 8. |
||
func_filenames = main_dataset.func | ||
confounds = main_dataset.confounds | ||
|
||
################################################################################ | ||
# Extract resting-state networks with DictionaryLearning | ||
|
@@ -45,7 +45,7 @@ | |
from nilearn.decomposition import DictLearning | ||
|
||
# Initialize DictLearning object | ||
dict_learn = DictLearning(n_components=5, smoothing_fwhm=6., | ||
dict_learn = DictLearning(n_components=8, smoothing_fwhm=6., | ||
memory="nilearn_cache", memory_level=2, | ||
random_state=0) | ||
# Fit to the data | ||
|
@@ -87,7 +87,7 @@ | |
# Visualization of region extraction results | ||
title = ('%d regions are extracted from %d components.' | ||
'\nEach separate color of region indicates extracted region' | ||
% (n_regions_extracted, 5)) | ||
% (n_regions_extracted, 8)) | ||
plotting.plot_prob_atlas(regions_extracted_img, view_type='filled_contours', | ||
title=title) | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KamalakerDadi , on this example, some of the visualizations of regions are broken: the contours are present, but not filled. Do you have an idea of why that might be the case?
https://3567-1235740-gh.circle-artifacts.com/0/home/circleci/project/doc/_build/html/auto_examples/03_connectivity/plot_compare_resting_state_decomposition.html#sphx-glr-auto-examples-03-connectivity-plot-compare-resting-state-decomposition-py
Do you have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well yeah I saw that and needs to be investigated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this looks good now ?
https://3645-1235740-gh.circle-artifacts.com/0/home/circleci/project/doc/_build/html/auto_examples/03_connectivity/plot_compare_resting_state_decomposition.html#sphx-glr-auto-examples-03-connectivity-plot-compare-resting-state-decomposition-py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is OK, but the CanICA components is probably not 32.
Also the images are extremely smooth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a bad sign or good sign ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the images downloaded smoothed? @emdupre @illdopejake , do you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK we did not additionally smooth them (please correct me if that's incorrect @illdopejake !), but they were smoothed prior to distributing as OpenNeuro derivatives. From the derivatives description:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct, we did not do any additional smoothing. It's possible that we could reach out to the Saxe lab to see if they would mind posted the unsmoothed data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any news on this non-smoothed data sharing aspect ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be easiest to reprocess them ourselves, but not sure if @illdopejake is in contact with Saxe lab.
If we do reprocess them ourselves I can run them through fMRIPrep on Compute Canada, but I need to set up an account. Not sure if you already have one we could submit through, Jake ? I have an fMRIPrep singularity image....