Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: small formatting fixes #1970

Merged
merged 4 commits into from Apr 15, 2019

Conversation

GaelVaroquaux
Copy link
Member

@GaelVaroquaux GaelVaroquaux commented Apr 12, 2019

I've just noticed that the releases had not been added to the front page. This PR adds them.

The PR also fixes minor problems fix the documentation.

@GaelVaroquaux GaelVaroquaux changed the title DOC: add releases to front page DOC: small formatting fixes Apr 12, 2019
@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #1970 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1970   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files         137      137           
  Lines       17766    17766           
=======================================
  Hits        16934    16934           
  Misses        832      832

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eff205...751eb72. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #1970 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1970   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files         137      137           
  Lines       17766    17766           
=======================================
  Hits        16934    16934           
  Misses        832      832

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eff205...751eb72. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #1970 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1970   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files         137      137           
  Lines       17766    17766           
=======================================
  Hits        16934    16934           
  Misses        832      832

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eff205...ba24b1c. Read the comment docs.

@kchawla-pi
Copy link
Collaborator

Cool! Thanks Gael.

Would you add a Known Issues section to the whats_new.rst, below the Fixes section for 0.5.1?
I drafted the text in a local branch, you can fix this and add it?

Known Issues
------------

- On Python2, ``plotting.view_connectome()`` & ``plotting.view_markers()``
  do not show parameters names in function signature
  when using help() and similar features.
  Please refer to the docstring for this information.

Also, I miss typed Contributors for 0.5.1, please fix that as well?

@kchawla-pi
Copy link
Collaborator

Hey, I will push the followup of my comments to this branch and merge this soon.
If you don't want me to do that let me know soon.

I am testing #1969 and in case of problems would like to do a clean revert, not have another merge after mine potentially complicating the revert.

@GaelVaroquaux
Copy link
Member Author

GaelVaroquaux commented Apr 13, 2019 via email

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides one smll glitch

- cmap is now edge_cmap
- threshold is now edge_threshold
- coords is now node_coord
- marker_size is noe node_size
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now

@kchawla-pi kchawla-pi merged commit c1c990f into nilearn:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants