New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: small formatting fixes #1970
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1970 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 137 137
Lines 17766 17766
=======================================
Hits 16934 16934
Misses 832 832 Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1970 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 137 137
Lines 17766 17766
=======================================
Hits 16934 16934
Misses 832 832 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1970 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 137 137
Lines 17766 17766
=======================================
Hits 16934 16934
Misses 832 832 Continue to review full report at Codecov.
|
Cool! Thanks Gael. Would you add a Known Issues
------------
- On Python2, ``plotting.view_connectome()`` & ``plotting.view_markers()``
do not show parameters names in function signature
when using help() and similar features.
Please refer to the docstring for this information.
Also, I miss typed |
Hey, I will push the followup of my comments to this branch and merge this soon. I am testing #1969 and in case of problems would like to do a clean revert, not have another merge after mine potentially complicating the revert. |
All is fine with me. Thanks!
Sent from my phone. Please forgive typos and briefness.
…On Apr 13, 2019, 09:12, at 09:12, Kshitij Chawla ***@***.***> wrote:
Hey, I will push the followup of my comments to this branch and merge
this soon.
If you don't want me to do that let me know soon.
I am testing #1969 and in case of problems would like to do a clean
revert, not have another merge after mine potentially complicating the
revert.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#1970 (comment)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides one smll glitch
- cmap is now edge_cmap | ||
- threshold is now edge_threshold | ||
- coords is now node_coord | ||
- marker_size is noe node_size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now
I've just noticed that the releases had not been added to the front page. This PR adds them.
The PR also fixes minor problems fix the documentation.