Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove is_valid filter #2169

Merged
merged 2 commits into from
Oct 28, 2019
Merged

remove is_valid filter #2169

merged 2 commits into from
Oct 28, 2019

Conversation

jeromedockes
Copy link
Member

closes #2168

bthirion
bthirion approved these changes Oct 13, 2019
View reviewed changes
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess thatthe travis failure is unrelated.

@jeromedockes
Copy link
Member Author

I guess thatthe travis failure is unrelated.

indeed the appveyor failure is a problem with the development dataset fetcher, unrelated

@codecov
Copy link

codecov bot commented Oct 13, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@4b1db88). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2169   +/-   ##
=========================================
  Coverage          ?   92.31%           
=========================================
  Files             ?      149           
  Lines             ?    18786           
  Branches          ?     2291           
=========================================
  Hits              ?    17342           
  Misses            ?      922           
  Partials          ?      522
Impacted Files Coverage Δ
nilearn/datasets/neurovault.py 88.68% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b1db88...7cc9f52. Read the comment docs.

@kchawla-pi kchawla-pi merged commit 053e5a8 into nilearn:master Oct 28, 2019
kchawla-pi added a commit to illdopejake/nilearn that referenced this pull request Nov 9, 2019
@kchawla-pi
Merge branch 'master' of https://github.com/nilearn/nilearn into spri…
f104d8c 
…nt_modify_fetch_dev

* 'master' of https://github.com/nilearn/nilearn:
  Verbose doc building to ease tracking of progress & diagnose stalls (nilearn#2203)
  New conda env is created once conda path has been activated
  Conda environment is created for full-builds
  Refactor CircleCI config for reduced redundancy (nilearn#2204)
  Installation should fail on Python < 3.5 (nilearn#2198)
  [MRG] Add get data function (nilearn#2172)
  fix error when colorscale given boolean array (nilearn#2193)
  remove is_valid filter (nilearn#2169)
  Moved new entries to next release
  FIX: marker size issue in plot_connectome nilearn#2185 (nilearn#2186)
  Updated Appveyor status badge
  Run tests on local Windows machines & Azure Pipelines (nilearn#2191)
  Updated requirements list for devs (nilearn#2190)
  Update azure-pipelines.yml for Azure Pipelines
  Release Nilearn 0.6.0 alpha (nilearn#2164)
  Making fetch_localizer_button_task backwards compatibile (nilearn#2182)
  [DOC] Update whats_new to reference nilearn#2013 (Merging of several examples) (nilearn#2183)
kchawla-pi added a commit to pausz/nilearn that referenced this pull request Nov 21, 2019
@kchawla-pi
Merge branch 'master' of https://github.com/nilearn/nilearn into fix-…
8507af9 
…smooth-image

* 'master' of https://github.com/nilearn/nilearn: (25 commits)
  Add testing for Nilearn setup & install & Fix the broken dependency installation (nilearn#2201)
  Fix uniform ball cloud test for sklearn >= 0.22 (nilearn#2175)
  MAINT: sklearn Deprecations (nilearn#2219)
  DOC: title in bold
  [DOC] Add note about decreasing memory usage (nilearn#2223)
  Rel 060b0 (nilearn#2208)
  Nilearn 0.6.0b0 release (nilearn#2206)
  Fixed the redundant & missing test case in merged PR nilearn#2035 (nilearn#2205)
  Modify fetch_development_fmri to fetch adults or children (nilearn#2035)
  Verbose doc building to ease tracking of progress & diagnose stalls (nilearn#2203)
  New conda env is created once conda path has been activated
  Conda environment is created for full-builds
  Refactor CircleCI config for reduced redundancy (nilearn#2204)
  Installation should fail on Python < 3.5 (nilearn#2198)
  [MRG] Add get data function (nilearn#2172)
  fix error when colorscale given boolean array (nilearn#2193)
  remove is_valid filter (nilearn#2169)
  Moved new entries to next release
  FIX: marker size issue in plot_connectome nilearn#2185 (nilearn#2186)
  Updated Appveyor status badge
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthirion bthirion bthirion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove is_valid from default neurovault filters?
3 participants
@jeromedockes @bthirion @kchawla-pi