New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 1% threshold in codecove yml #2434
Conversation
this should reduce noise of checks failing with "+- .01%" diff coverage etc. 1% is the value used by scikit-learn
Codecov Report
@@ Coverage Diff @@
## master #2434 +/- ##
=======================================
Coverage 92.30% 92.31%
=======================================
Files 180 180
Lines 23693 23721 +28
Branches 2824 2828 +4
=======================================
+ Hits 21871 21897 +26
- Misses 1186 1187 +1
- Partials 636 637 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx.
patch: | ||
default: | ||
# Be tolerant on slight code coverage diff on PRs to limit | ||
# noisy red coverage status on github PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth also including the comment from sklearn about using the browser extension ?
# Note The coverage stats are still uploaded
# to codecov so that PR reviewers can see uncovered lines
# in the github diff if they install the codecov browser
# extension:
# https://github.com/codecov/browser-extension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small, non-substantive question. But regardless, I think this will make a big difference to the contributor experience ! Thanks !!
Is it worth also including the comment from sklearn about using the browser extension ?
I think it may be outdated; I can see coverage reports online and I
haven't installed any extension
|
You're right; I think it's outdated ! I remembered using the extension at some point (I think I installed it on an older computer), but it looks like it's totally deprecated, now. Maybe worth an issue in sklearn :) |
this should reduce noise of checks failing with "+- .01%" diff coverage etc.
1% is the value used by scikit-learn