Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface plots #2477

Merged
merged 58 commits into from
Jun 30, 2020
Merged

Surface plots #2477

merged 58 commits into from
Jun 30, 2020

Commits on Jan 20, 2019

  1. Add plot_surf_montage

    @dangom
    dangom committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    0201b22 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2019

  1. Fix float division by zero in Python 2 in plot_surf_montage

    @dangom
    dangom committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    78bec87 View commit details
    Browse the repository at this point in the history

  2. Rename plot_surf_montage to plot_img_on_surf

    @dangom
    dangom committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    ea0dd3f View commit details
    Browse the repository at this point in the history

  3. Move _check_mesh from html_surface into check_mesh in surface. 

    The reason is use check_mesh also in plot_img_on_surf
    @dangom
    dangom committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    55fb7a7 View commit details
    Browse the repository at this point in the history

  4. Plot_img_on_surf now uses check_mesh

    @dangom
    dangom committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    4d87ae9 View commit details
    Browse the repository at this point in the history

  5. Improve handling of keyword args in plot_img_on_surf 

    Instead of popping keyword arguments from a kwargs dictionary, add
options directly as individual keyword args to plot_img_on_surf
    @dangom
    dangom committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    d334693 View commit details
    Browse the repository at this point in the history

  6. Factor out plot_img_on_surf's colorbar code into a helper function

    @dangom
    dangom committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    867a01e View commit details
    Browse the repository at this point in the history

  7. Improve docs related to surf_mesh 

    Docs where missing or incomplete in surface.check_mesh
and plotting.surf_plotting
    @dangom
    dangom committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    983745b View commit details
    Browse the repository at this point in the history

  8. Move cmap to a keyword argument in plot_img_on_surf

    @dangom
    dangom committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    f31bd3c View commit details
    Browse the repository at this point in the history

  9. Fix plot_img_on_surf surf_mesh default. From None to fsaverage5

    @dangom
    dangom committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    f32e614 View commit details
    Browse the repository at this point in the history

  10. Add more tests.

    @dangom
    dangom committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    1ce4aad View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. Update examples/01_plotting/plot_img_on_surf.py 

    Co-Authored-By: dangom <d.gomez@donders.ru.nl>
    @jeromedockes
    jeromedockes and dangom committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    e4e7a9e View commit details
    Browse the repository at this point in the history

  2. Update examples/01_plotting/plot_img_on_surf.py 

    Co-Authored-By: dangom <d.gomez@donders.ru.nl>
    @jeromedockes
    jeromedockes and dangom committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    1388051 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. Move plot_img_on_surf example to plot_3d_map_to_surface_projection

    @dangom
    dangom committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    31a7991 View commit details
    Browse the repository at this point in the history

  2. Remove unused import in surf_plotting.py

    @dangom
    dangom committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    648fa94 View commit details
    Browse the repository at this point in the history

  3. Make 'cold_hot' the default cmap in plot_img_on_surf

    @dangom
    dangom committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    7bdd9c1 View commit details
    Browse the repository at this point in the history

  4. Use safeguard check_niimg_3d to plot_img_on_surf

    @dangom
    dangom committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    2dc314f View commit details
    Browse the repository at this point in the history

Commits on May 21, 2020

  1. Merged latest master into @dangom's/surf_montage.

    @ZviBaratz
    ZviBaratz committed May 21, 2020
    Configuration menu
    Copy the full SHA
    35e30c3 View commit details
    Browse the repository at this point in the history

  2. Fixed surface module's tests.

    @ZviBaratz
    ZviBaratz committed May 21, 2020
    Configuration menu
    Copy the full SHA
    66c2a47 View commit details
    Browse the repository at this point in the history

  3. Fixed the test failure. It was caused by a line I missed in the merge.

    @ZviBaratz
    ZviBaratz committed May 21, 2020
    Configuration menu
    Copy the full SHA
    14fac1a View commit details
    Browse the repository at this point in the history

Commits on May 30, 2020

  1. Merged upstream and added examples artifacts to gitignore.

    @ZviBaratz
    ZviBaratz committed May 30, 2020
    Configuration menu
    Copy the full SHA
    e2dd639 View commit details
    Browse the repository at this point in the history

  2. Added plot_img_on_surf() to reference.rst and made tiny styling fixes… 

    … to the docstring.
    @ZviBaratz
    ZviBaratz committed May 30, 2020
    Configuration menu
    Copy the full SHA
    1a50359 View commit details
    Browse the repository at this point in the history

  3. Added a What's New entry for plot_img_on_surf().

    @ZviBaratz
    ZviBaratz committed May 30, 2020
    Configuration menu
    Copy the full SHA
    fc0aaa1 View commit details
    Browse the repository at this point in the history

  4. Added some missing tests for plot_img_on_surf().

    @ZviBaratz
    ZviBaratz committed May 30, 2020
    Configuration menu
    Copy the full SHA
    63129da View commit details
    Browse the repository at this point in the history

  5. Changed relative imports to absolute imports in surf_plotting.py.

    @ZviBaratz
    ZviBaratz committed May 30, 2020
    Configuration menu
    Copy the full SHA
    05d2510 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2020

  1. Merge branch 'master' into surface_plots

    @ZviBaratz
    ZviBaratz committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    a1895fc View commit details
    Browse the repository at this point in the history

  2. Merged master and edited plot_img_on_surf() docstring to fix RST inde… 

    …ntation warning.
    @ZviBaratz
    ZviBaratz committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    a62f0fc View commit details
    Browse the repository at this point in the history

  3. Another round with Sphinx.

    @ZviBaratz
    ZviBaratz committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    5eaad19 View commit details
    Browse the repository at this point in the history

  4. Updated test surface fetch method and resolved linting issues.

    @ZviBaratz
    ZviBaratz committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    d4cb770 View commit details
    Browse the repository at this point in the history

  5. Fixed to conform with the default flake8 max-line-length configuration.

    @ZviBaratz
    ZviBaratz committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    74c016e View commit details
    Browse the repository at this point in the history

  6. Sphinx U+1F3F3

    @ZviBaratz
    ZviBaratz committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    d4c1a88 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2020

  1. Added .vscode to gitignore and organized a bit.

    @ZviBaratz
    ZviBaratz committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    c0c4f58 View commit details
    Browse the repository at this point in the history

  2. Changed test_plot_img_on_surf_output_file() in attempt to solve build… 

    … error with Python 3.5.
    @ZviBaratz
    ZviBaratz committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    56de47c View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2020

  1. Merge branch 'master' into surface_plots

    @ZviBaratz
    ZviBaratz committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    6db1144 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2020

  1. Fixed horizontal squeeze by adding an aspect_ratio parameter to plot_… 

    …img_on_surf().
    @ZviBaratz
    ZviBaratz committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    e3e993b View commit details
    Browse the repository at this point in the history

  2. Fixed bad :func: directive in plot_img_on_surf() example.

    @ZviBaratz
    ZviBaratz committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    7f55423 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. Update examples/01_plotting/plot_3d_map_to_surface_projection.py 

    Co-authored-by: Elizabeth DuPre <emd222@cornell.edu>
    @ZviBaratz @emdupre
    ZviBaratz and emdupre committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    962e13f View commit details
    Browse the repository at this point in the history

  2. Removed length check from _check_hemisphere()

    @ZviBaratz
    ZviBaratz committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    ebb7e6f View commit details
    Browse the repository at this point in the history

  3. Proposed Orientation Enum for surface plotting configuration.

    @ZviBaratz
    ZviBaratz committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    e95c882 View commit details
    Browse the repository at this point in the history

  4. Updated example to comply with changing the display_mode parameter to… 

    … orientation.
    @ZviBaratz
    ZviBaratz committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    c150fdf View commit details
    Browse the repository at this point in the history

  5. Reverted Enum creation and updated plot_img_on_surf's hemispheres par… 

    …amater to use a list.
    @ZviBaratz
    ZviBaratz committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    d218a82 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. Reverted changes to gitignore.

    @ZviBaratz
    ZviBaratz committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    bb118d7 View commit details
    Browse the repository at this point in the history

  2. Removed obj domain referencing in docstrings.

    @ZviBaratz
    ZviBaratz committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    942fa0f View commit details
    Browse the repository at this point in the history

  3. Removed f-strings to maintain python 3.5 compatibility.

    @ZviBaratz
    ZviBaratz committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    3034054 View commit details
    Browse the repository at this point in the history

  4. Fixed missed f-strings.

    @ZviBaratz
    ZviBaratz committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    1c617f2 View commit details
    Browse the repository at this point in the history

  5. Fixed error message strings in _check_views() and _check_hemispheres().

    @ZviBaratz
    ZviBaratz committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    f6ccb9f View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. Reverted image module docstring fixes.

    @ZviBaratz
    ZviBaratz committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    03a2e78 View commit details
    Browse the repository at this point in the history

  2. Made check_mesh() private.

    @ZviBaratz
    ZviBaratz committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    9ede345 View commit details
    Browse the repository at this point in the history

  3. Reverted img_plotting module docstring fixes.

    @ZviBaratz
    ZviBaratz committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    b357672 View commit details
    Browse the repository at this point in the history

  4. Removed list conversion in _check_hemispehres() and _check_views() an… 

    …d updated tests and docstrings for these functions.
    @ZviBaratz
    ZviBaratz committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    da9d243 View commit details
    Browse the repository at this point in the history

  5. Made 'fsaverage5' plot_img_on_surf()'s default surf_mesh value and up… 

    …dated tests.
    @ZviBaratz
    ZviBaratz committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    44646f4 View commit details
    Browse the repository at this point in the history

  6. Added a try-except block to remove plot_img_on_surf()'s output file a… 

    …fter running the relevant test even if it fails.
    @ZviBaratz
    ZviBaratz committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    ac23a61 View commit details
    Browse the repository at this point in the history

  7. Changed test_plot_img_on_surf_output_file() to use pytest's tmp_path … 

    …fixture.
    @ZviBaratz
    ZviBaratz committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    3c84edc View commit details
    Browse the repository at this point in the history

  8. Fixed plot_img_on_surf()'s aspect ratio parameter to default to 1.4 a… 

    …nd multiply itself by len(hemispehres) when determining figsize.
    @ZviBaratz
    ZviBaratz committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    5f5d3e8 View commit details
    Browse the repository at this point in the history

  9. Removed symmetric_cbar parameter from plot_img_on_surf().

    @ZviBaratz
    ZviBaratz committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    9f8fbc6 View commit details
    Browse the repository at this point in the history

  10. Removed symmetric_cbar parameter from _colorbar_from_array().

    @ZviBaratz
    ZviBaratz committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    52794d6 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. Reverted changes to the image.py module.

    @ZviBaratz
    ZviBaratz committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    d7daa31 View commit details
    Browse the repository at this point in the history

  2. Merged changes from master.

    @ZviBaratz
    ZviBaratz committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    6feb6ba View commit details
    Browse the repository at this point in the history