New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] get_clusters_table: ensure input is 3D and accept filenames #2701
[FIX] get_clusters_table: ensure input is 3D and accept filenames #2701
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2701 +/- ##
==========================================
+ Coverage 87.59% 87.61% +0.02%
==========================================
Files 100 100
Lines 13169 13171 +2
Branches 2555 2555
==========================================
+ Hits 11535 11540 +5
+ Misses 1026 1024 -2
+ Partials 608 607 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor style issue, but overall this fix looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx !
* 'master' of github.com:nilearn/nilearn: Release 0.7.1 (nilearn#2727) Add two_sided flag to get_clusters_table (nilearn#2719) bugfix resample only if type is not contour or contourf (nilearn#2656) Support atlases in plot_carpet (nilearn#2702) Fix whatsnew entry with public function reference (nilearn#2716) EHN signal.clean standardise option PSC to allow negative mean signal (nilearn#2714) Replace NaNs with zeros in NiftiLabelsMasker (nilearn#2712) [MRG] Allow asymmetric matrices in plot_connectome (nilearn#2703) [MRG] Mosaic mode of displaying brain images (nilearn#2684) Resampling functionality for NeuroVault (nilearn#2696) Solving "NiftiMapsMasker and NiftiLabelsMasker cannot transform 3D images" (nilearn#2708) Raise warning for FirstLevelModel fit when confounds and design_matrices are both specified (nilearn#2710) Fixed numpy warning when img has NaNs. (nilearn#2709) [MRG] High variance confounds in maskers (nilearn#2697) fix sampling (nilearn#2706) [MRG] Handle nans in surf plotting (nilearn#2691) [FIX] get_clusters_table: ensure input is 3D and accept filenames (nilearn#2701) Warn in nifti masker report when no image provided to fit (nilearn#2694) fix for FirstLevelModel compute_contrast for multiple runs with varying matrice size or columns (nilearn#2688)
Closes #2700 .
Changes proposed in this pull request: