Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.10.0 #3454

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Release 0.10.0 #3454

merged 1 commit into from
Jan 6, 2023

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Jan 4, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention "Closes #XXXX"
  • Code is PEP8-compliant.
  • Changelog or what's new entry in "doc/changes/latest.rst"
  • (Bug fixes) There is at least one test that would fail under the original bug conditions.
  • (New features) There is at least one unit test per new function / class.
  • (New features) The new feature is demoed in at least one relevant example.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #3454 (dc15d19) into main (9a49cae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3454   +/-   ##
=======================================
  Coverage   90.94%   90.94%           
=======================================
  Files         133      133           
  Lines       15334    15334           
  Branches     3023     3023           
=======================================
  Hits        13946    13946           
  Misses        820      820           
  Partials      568      568           
Impacted Files Coverage Δ
nilearn/image/image.py 95.73% <ø> (ø)
nilearn/interfaces/bids/_utils.py 97.14% <ø> (ø)
nilearn/interfaces/bids/glm.py 92.64% <ø> (ø)
nilearn/maskers/nifti_labels_masker.py 89.59% <ø> (ø)
nilearn/mass_univariate/permuted_least_squares.py 89.85% <ø> (ø)
nilearn/regions/signal_extraction.py 92.70% <ø> (ø)
nilearn/reporting/_get_clusters_table.py 97.05% <ø> (ø)
nilearn/reporting/glm_reporter.py 93.85% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx !

Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ymzayek ! This LGTM ! 👍
Wondering whether we should try to merge #3453 for the release, and rebase to avoid tagging a commit with test failures.
Might also be worth triggering a full documentation build before merging.

@ymzayek
Copy link
Member Author

ymzayek commented Jan 5, 2023

@NicolasGensollen yes those are good points thanks!

@jeromedockes
Copy link
Member

re the pep8 checks that gives spurious failures since the last flake8 release, until we have a solution should we temporarily disable the workflow ?

@ymzayek
Copy link
Member Author

ymzayek commented Jan 5, 2023

@jeromedockes yes I'll get on that tomorrow. Thanks for the reminder!

@jeromedockes
Copy link
Member

yes I'll get on that tomorrow

ok I just disabled it then. to re-enable it we just have to go to github actions, select that workflow and click "enable workflow"

@ymzayek
Copy link
Member Author

ymzayek commented Jan 6, 2023

ok I just disabled it then. to re-enable it we just have to go to github actions, select that workflow and click "enable workflow"

Great thanks!

@ymzayek
Copy link
Member Author

ymzayek commented Jan 6, 2023

Will merge. Full documentation build has no errors and I checked the pages locally by downloading the build docs from the Action.
This can be found here: https://github.com/nilearn/nilearn/actions/runs/3854496832
(hosting seems to have not been triggered but I'll look into this separately - I think I just need to update the permissions)

@ymzayek ymzayek merged commit 9c29e33 into nilearn:main Jan 6, 2023
@bthirion
Copy link
Member

bthirion commented Jan 6, 2023

Thx !

@ymzayek ymzayek deleted the REL-0.10.0 branch February 24, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants