-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-release 0.10.1rc1 #3536
Pre-release 0.10.1rc1 #3536
Conversation
👋 @ymzayek Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #3536 +/- ##
=======================================
Coverage 90.99% 90.99%
=======================================
Files 133 133
Lines 15365 15365
Branches 3207 3207
=======================================
Hits 13982 13982
Misses 819 819
Partials 564 564 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
When do you do the pre-release ? |
5045425
to
dd6919c
Compare
I can do it today or tomorrow. We should hold off on merging anything else at this point until I do the release and a post-release PR. Once the tests pass I'd say it's ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good with me but let me know if I should make a mention of the changes in terms of formatting.
I am starting to feel that it may be better to keep track regularly of those changes rather than having a single entry "in the end" because the end may take a while to get there and some changes involve more than just "reformatting" so it may help to have some bread crumbs for those in the changelog.
@Remi-Gau we could go ahead and add it in this PR. Maybe an entry (or more if needed) under changes? I think it's worth mentioning the reformatting since this could concern contributors in general, however I think I would still leave CI stuff out. I was actually thinking to open an issue/PR to add to this README file to document everything that's happening with the CI (specifically GitHub Actions). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Remi-Gau would it suffice to add this? - Modules :mod:`~nilearn.decomposition` and :mod:`~nilearn.decoding` code and docstrings have been reformatted using black. Changes resulted in improved readability overall and increased consistency (:gh:`3491` and :gh:`3484` by `Remi Gau`_). |
Yes that's good with me. Thanks. |
eaf7759
to
733055a
Compare
Merging this. Then will tag it, build, and upload the distributions to pypi and github |
* REL 0.10.1rc1 * Set version marker * Modify changelog
No description provided.