Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-release 0.10.1rc1 #3536

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Pre-release 0.10.1rc1 #3536

merged 3 commits into from
Feb 28, 2023

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Feb 24, 2023

No description provided.

@github-actions
Copy link
Contributor

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #3536 (733055a) into main (867d6f1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3536   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files         133      133           
  Lines       15365    15365           
  Branches     3207     3207           
=======================================
  Hits        13982    13982           
  Misses        819      819           
  Partials      564      564           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bthirion
Copy link
Member

When do you do the pre-release ?

@ymzayek
Copy link
Member Author

ymzayek commented Feb 27, 2023

I can do it today or tomorrow. We should hold off on merging anything else at this point until I do the release and a post-release PR. Once the tests pass I'd say it's ready.

Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with me but let me know if I should make a mention of the changes in terms of formatting.

I am starting to feel that it may be better to keep track regularly of those changes rather than having a single entry "in the end" because the end may take a while to get there and some changes involve more than just "reformatting" so it may help to have some bread crumbs for those in the changelog.

@ymzayek
Copy link
Member Author

ymzayek commented Feb 27, 2023

@Remi-Gau we could go ahead and add it in this PR. Maybe an entry (or more if needed) under changes? I think it's worth mentioning the reformatting since this could concern contributors in general, however I think I would still leave CI stuff out. I was actually thinking to open an issue/PR to add to this README file to document everything that's happening with the CI (specifically GitHub Actions).

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymzayek
Copy link
Member Author

ymzayek commented Feb 27, 2023

@Remi-Gau would it suffice to add this?

- Modules :mod:`~nilearn.decomposition` and :mod:`~nilearn.decoding` code and docstrings have been reformatted using black. Changes resulted in improved readability overall and increased consistency (:gh:`3491` and :gh:`3484` by `Remi Gau`_).

@Remi-Gau
Copy link
Collaborator

@Remi-Gau would it suffice to add this?

- Modules :mod:`~nilearn.decomposition` and :mod:`~nilearn.decoding` code and docstrings have been reformatted using black. Changes resulted in improved readability overall and increased consistency (:gh:`3491` and :gh:`3484` by `Remi Gau`_).

Yes that's good with me. Thanks.

@ymzayek
Copy link
Member Author

ymzayek commented Feb 28, 2023

Merging this. Then will tag it, build, and upload the distributions to pypi and github

@ymzayek ymzayek merged commit aa480ce into nilearn:main Feb 28, 2023
michellewang pushed a commit to michellewang/nilearn that referenced this pull request Mar 8, 2023
* REL 0.10.1rc1

* Set version marker

* Modify changelog
@ymzayek ymzayek deleted the REL-0.10.1rc1 branch March 21, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants