New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] move defaults in docs.py #3621
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
We can use this PR to start make sure we agree on where and how defaults should be reported and add an example in the contributing doc. The changes here are supposed to reflect what was decided at the last maintainers meeting. |
Codecov Report
@@ Coverage Diff @@
## main #3621 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 133 133
Lines 15629 15629
Branches 3250 3250
=======================================
Hits 14307 14307
Misses 774 774
Partials 548 548
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
the merge conflict is a headache: doing a hard reset on this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started commenting the defaults that are not defined in docs.py but maybe a separate PR is needed to resolve these. There are 2 cases: defaults are not defined at all and defaults are set in the docstrings where the standard parameter is referenced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
Co-authored-by: bthirion <bertrand.thirion@inria.fr>
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise.
Co-authored-by: bthirion <bertrand.thirion@inria.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Relates to #3519
Changes proposed in this pull request: