-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] Update config for formatting of nilearn/datasets #3697
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #3697 +/- ##
=======================================
Coverage 91.57% 91.57%
=======================================
Files 139 139
Lines 16576 16576
Branches 3233 3233
=======================================
Hits 15179 15179
Misses 1394 1394
Partials 3 3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
closes #3624 as this is the last PR that it was split into. |
will fix remaining flake8 issues in this PR: probably style regressions from other PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but beware the MacOS failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Remi-Gau !
Thanks for catching this one. @bthirion. |
Reopened #3573 as the test failure on MacOS / Ptyhon 3.10 was the second occurrence of a flaky test. thanks @bthirion @ymzayek @NicolasGensollen for the reviews |
Relates #2528
Splinter of #3624
Changes proposed in this pull request:
Changes proposed in this pull request:
to be merged after: