Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Update config for formatting of nilearn/datasets #3697

Merged
merged 4 commits into from
Apr 25, 2023

Conversation

Remi-Gau
Copy link
Collaborator

Relates #2528

Splinter of #3624

Changes proposed in this pull request:

Changes proposed in this pull request:

  • update files include in pre-commit config
  • update files excluding in pre-commit
  • update flake8 / isort CI

to be merged after:

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2023

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #3697 (650068d) into main (51a651c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3697   +/-   ##
=======================================
  Coverage   91.57%   91.57%           
=======================================
  Files         139      139           
  Lines       16576    16576           
  Branches     3233     3233           
=======================================
  Hits        15179    15179           
  Misses       1394     1394           
  Partials        3        3           
Impacted Files Coverage Δ
nilearn/datasets/_testing.py 96.31% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Remi-Gau Remi-Gau marked this pull request as ready for review April 24, 2023 12:44
@Remi-Gau
Copy link
Collaborator Author

closes #3624 as this is the last PR that it was split into.

@Remi-Gau
Copy link
Collaborator Author

will fix remaining flake8 issues in this PR: probably style regressions from other PR.

Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but beware the MacOS failure.

Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Remi-Gau !

@Remi-Gau
Copy link
Collaborator Author

LGTM, but beware the MacOS failure.

Thanks for catching this one. @bthirion.
Seems unrelated. Need to check if this is not related to this flaky test I noticed a couple of months ago.

@Remi-Gau
Copy link
Collaborator Author

Reopened #3573 as the test failure on MacOS / Ptyhon 3.10 was the second occurrence of a flaky test.
But will merge as this is unrelated to this PR.

thanks @bthirion @ymzayek @NicolasGensollen for the reviews

@Remi-Gau Remi-Gau merged commit 54aed73 into nilearn:main Apr 25, 2023
29 checks passed
@Remi-Gau Remi-Gau moved this from In progress to Done in R&R (reformat and refactor) Apr 25, 2023
@Remi-Gau Remi-Gau deleted the maint/format-dataset_config branch April 26, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants