New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] improve test coverage BaseMasker #3721
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #3721 +/- ##
==========================================
+ Coverage 91.58% 91.60% +0.02%
==========================================
Files 139 139
Lines 16596 16596
Branches 3243 3243
==========================================
+ Hits 15199 15203 +4
+ Misses 1394 1390 -4
Partials 3 3 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks!
OK will merge and then rebase #3685 |
closes none
relates to [MAINT] refactor nilearn/maskers (sourcery, f-strings) #3685
add test to improve test coverage of BaseMasker.fit_transform
is only meant to check that the test pass on main before refactoring, to ensure behavior consistency in [MAINT] refactor nilearn/maskers (sourcery, f-strings) #3685