Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] improve test coverage BaseMasker #3721

Merged
merged 4 commits into from Jun 12, 2023

Conversation

Remi-Gau
Copy link
Collaborator

@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2023

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #3721 (c6a69f7) into main (b576d9f) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3721      +/-   ##
==========================================
+ Coverage   91.58%   91.60%   +0.02%     
==========================================
  Files         139      139              
  Lines       16596    16596              
  Branches     3243     3243              
==========================================
+ Hits        15199    15203       +4     
+ Misses       1394     1390       -4     
  Partials        3        3              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Remi-Gau Remi-Gau marked this pull request as ready for review June 12, 2023 10:09
@Remi-Gau Remi-Gau changed the title [WIP] improve coverage BaseMasker - do not merge [WIP] improve test coverage BaseMasker Jun 12, 2023
@Remi-Gau Remi-Gau changed the title [WIP] improve test coverage BaseMasker [MAINT] improve test coverage BaseMasker Jun 12, 2023
Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@Remi-Gau
Copy link
Collaborator Author

OK will merge and then rebase #3685

@Remi-Gau Remi-Gau merged commit 442133d into nilearn:main Jun 12, 2023
29 checks passed
@Remi-Gau Remi-Gau deleted the test-basemasker branch June 12, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants