[MAINT] refactor nilearn/maskers (sourcery, f-strings)

[Remi-Gau]

Relates to #2528

Changes proposed in this pull request:

• apply sourcery refactoring suggestions
• use f strings everywhere

[github-actions]

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

• PR has an interpretable title.
• PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
• Code is PEP8-compliant (see our documentation on coding style)
• Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

• There is at least one unit test per new function / class (see our documentation on testing)
• The new feature is demoed in at least one relevant example.

For bug fixes:

• There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

[codecov]

Codecov Report

Merging #3685 (9568c7c) into main (442133d) will decrease coverage by 0.01%.
The diff coverage is 93.84%.

@@            Coverage Diff             @@
##             main    #3685      +/-   ##
==========================================
- Coverage   91.60%   91.60%   -0.01%     
==========================================
  Files         139      139              
  Lines       16596    16589       -7     
  Branches     3243     3242       -1     
==========================================
- Hits        15203    15196       -7     
  Misses       1390     1390              
  Partials        3        3              

Impacted Files	Coverage Δ
nilearn/maskers/nifti_spheres_masker.py	96.57% <50.00%> (ø)
nilearn/maskers/base_masker.py	92.30% <85.71%> (ø)
nilearn/maskers/nifti_masker.py	91.66% <87.50%> (-0.18%)	⬇️
nilearn/maskers/_masker_validation.py	100.00% <100.00%> (ø)
nilearn/maskers/nifti_labels_masker.py	93.64% <100.00%> (-0.08%)	⬇️
nilearn/maskers/nifti_maps_masker.py	97.70% <100.00%> (-0.03%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[bthirion]

LGTM otherwise

[bthirion]

I'm a bit unsure here, because the new code does not result exactly in the same calls, and it is not covered by tests...

[ymzayek]

Maybe in such cases it might be better to increase test coverage before refactoring when there is a big amount of untested lines

[Remi-Gau]

you read my mind

[bthirion]

The changes LGTM, but shouldn't we take care of the tests ?

[Remi-Gau]

The changes LGTM, but shouldn't we take care of the tests ?

did you mean:

• improving test coverage, or
• refactor the tests, or
• something else entirely?

[ymzayek]

@Remi-Gau how do you want to proceed with this? Should we merge #3721 first, then rebase this on main and see if any tests break with the refactoring?

[Remi-Gau]

@Remi-Gau how do you want to proceed with this? Should we merge #3721 first, then rebase this on main and see if any tests break with the refactoring?

Yes let's do this.
Will make sure that #3721 is all green first.

[bthirion]

I can't spot any issue.

[ymzayek]

LGTM as well!

[Remi-Gau]

Thanks for the reviews.
Merging