Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.10.1 #3724

Merged
merged 8 commits into from
Apr 27, 2023
Merged

Release 0.10.1 #3724

merged 8 commits into from
Apr 27, 2023

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Apr 26, 2023

Closes # .

Changes proposed in this pull request:

@ymzayek ymzayek requested a review from Remi-Gau April 26, 2023 08:15
@github-actions
Copy link
Contributor

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #3724 (b82b259) into main (1b79941) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3724   +/-   ##
=======================================
  Coverage   91.57%   91.57%           
=======================================
  Files         139      139           
  Lines       16577    16577           
  Branches     3233     3233           
=======================================
  Hits        15180    15180           
  Misses       1394     1394           
  Partials        3        3           
Impacted Files Coverage Δ
nilearn/glm/first_level/first_level.py 96.80% <ø> (ø)
nilearn/interfaces/bids/glm.py 95.58% <ø> (ø)
nilearn/reporting/_get_clusters_table.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT, thx.

Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ymzayek !

@ymzayek ymzayek marked this pull request as ready for review April 27, 2023 13:40
@ymzayek
Copy link
Member Author

ymzayek commented Apr 27, 2023

Ok merging thx all! @Remi-Gau and I will meet tomorrow morning to do the release

@ymzayek ymzayek merged commit 3214944 into nilearn:main Apr 27, 2023
29 checks passed
@ymzayek ymzayek deleted the REL-0.10.1 branch April 27, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants