New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] find confounds even when BIDS derivatives bold files contain res or den entities #3742
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #3742 +/- ##
==========================================
- Coverage 91.60% 91.54% -0.07%
==========================================
Files 139 139
Lines 16593 16591 -2
Branches 3244 3244
==========================================
- Hits 15200 15188 -12
- Misses 1390 1402 +12
+ Partials 3 1 -2
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Minor comments
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
all green merging |
Fixes #3741
Changes proposed in this pull request:
first_level_from_bids
more stringent by checking the types of the output values