Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] fix f strings #3770

Merged
merged 8 commits into from Jun 21, 2023
Merged

[REF] fix f strings #3770

merged 8 commits into from Jun 21, 2023

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Jun 20, 2023

Relates to #2528

Changes proposed in this pull request:

  • format remaining f strings in
    • examples
    • maskers
    • reporting
    • utils

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2023

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #3770 (dbac40f) into main (6a576e5) will increase coverage by 0.00%.
The diff coverage is 95.23%.

@@           Coverage Diff           @@
##             main    #3770   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         139      139           
  Lines       16554    16562    +8     
  Branches     3230     3229    -1     
=======================================
+ Hits        15172    15180    +8     
  Misses       1379     1379           
  Partials        3        3           
Impacted Files Coverage Δ
nilearn/_utils/helpers.py 78.26% <0.00%> (ø)
nilearn/_utils/param_validation.py 100.00% <ø> (ø)
nilearn/_utils/testing.py 68.68% <ø> (ø)
nilearn/datasets/func.py 86.03% <ø> (ø)
nilearn/interfaces/bids/_utils.py 100.00% <ø> (ø)
..._testing/_glm_reporter_visual_inspection_suite_.py 88.23% <ø> (ø)
nilearn/_utils/data_gen.py 98.43% <100.00%> (ø)
nilearn/_utils/extmath.py 94.73% <100.00%> (ø)
nilearn/_utils/niimg.py 99.01% <100.00%> (ø)
nilearn/maskers/nifti_labels_masker.py 93.78% <100.00%> (+0.14%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Remi-Gau Remi-Gau marked this pull request as ready for review June 20, 2023 11:07
@Remi-Gau
Copy link
Collaborator Author

There should be one more PR for f strings after that and then nilearn should be fully f stringified

@Remi-Gau Remi-Gau changed the title [REF] fix fstrings in examples [REF] fix f strings Jun 20, 2023
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx !

@Remi-Gau Remi-Gau merged commit a03175b into nilearn:main Jun 21, 2023
29 checks passed
@Remi-Gau Remi-Gau deleted the more_f_strings branch June 25, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants