New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] Update config black and pre-commit #3777
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #3777 +/- ##
=======================================
Coverage 91.65% 91.65%
=======================================
Files 139 139
Lines 16562 16562
Branches 3229 3229
=======================================
Hits 15180 15180
Misses 1379 1379
Partials 3 3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far.
Note that all CI jobs are finished but the UI shows them as still running. Not sure what happened on the azure python 3.11. |
FYI @bthirion |
Sure. Do you undertsand the CI failures ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nope: trying to move to GH action only in #3780 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
OK I will merge this as I think it is pretty clear by now that the CI fails are not related to the content of the PR |
Relates to #2528
Changes proposed in this pull request:
This results in very long "exclude" sections but brings us closer to the end goal of running black and pre-commit on everything: now we are at the stage of run on "everything minus those 100 files".
pre-commit run -a
to apply all hooks and check that no further change is done by runningblack .
following PRs will just gradually remove files from those exclude sections and re-apply black.