Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] address flaky tests in CI #3785

Merged
merged 15 commits into from
Jun 29, 2023
Merged

[FIX] address flaky tests in CI #3785

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
02805f2
remove duplicate tests
Remi-Gau Jun 28, 2023
d4c15c2
Merge remote-tracking branch 'upstream/main' into ci_fix
Remi-Gau Jun 28, 2023
bbc79c6
skip test for now
Remi-Gau Jun 28, 2023
b1a26bb
only skip test
Remi-Gau Jun 28, 2023
45b1f84
silence more tests
Remi-Gau Jun 28, 2023
f0523e6
ignore all parcellations tests
Remi-Gau Jun 28, 2023
f9bcc68
skip one more test
Remi-Gau Jun 28, 2023
ea20e4e
only run parcellation tests
Remi-Gau Jun 28, 2023
731f797
refactor tests
Remi-Gau Jun 28, 2023
aa8a41c
reintroduce test
Remi-Gau Jun 28, 2023
0df9e59
reintroduce test
Remi-Gau Jun 28, 2023
964aa3e
bring yet another test back in
Remi-Gau Jun 29, 2023
1aa6486
switch ubuntu version for doc
Remi-Gau Jun 29, 2023
0ac18e5
test on all
Remi-Gau Jun 29, 2023
b4e81c4
use latet
Remi-Gau Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 0 additions & 12 deletions nilearn/regions/tests/test_parcellations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,18 +109,6 @@ def test_parcellations_fit_on_multi_nifti_images(method, test_image):

assert parcellator.labels_img_ is not None

parcellator = Parcellations(method="rena", n_parcels=5, verbose=0)
parcellator.fit(fmri_imgs)

assert parcellator.labels_img_ is not None

parcellator = Parcellations(
method="hierarchical_kmeans", n_parcels=5, verbose=0
)
parcellator.fit(fmri_imgs)

assert parcellator.labels_img_ is not None

Comment on lines -112 to -123
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both rena and hierarchical_kmeans were actually included in the parametrization of this test

# Smoke test with explicit mask image
mask_img = np.ones((10, 11, 12))
mask_img = Nifti1Image(mask_img, AFFINE_EYE)
Expand Down