[FIX] address flaky tests in CI

[Remi-Gau]

Closes #3784

Changes proposed in this pull request:

• removes a duplicate tests in the "allegedly" problematic test

[Remi-Gau]

both rena and hierarchical_kmeans were actually included in the parametrization of this test

[github-actions]

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

• PR has an interpretable title.
• PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
• Code is PEP8-compliant (see our documentation on coding style)
• Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

• There is at least one unit test per new function / class (see our documentation on testing)
• The new feature is demoed in at least one relevant example.

For bug fixes:

• There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

[codecov]

Codecov Report

Merging #3785 (b4e81c4) into main (7d91e88) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3785   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         133      133           
  Lines       15557    15561    +4     
  Branches     3229     3229           
=======================================
+ Hits        14238    14242    +4     
  Misses        772      772           
  Partials      547      547           

Flag	Coverage Δ
macos-latest_3.10	91.44% <ø> (?)
macos-latest_3.11	91.44% <ø> (+<0.01%)	⬆️
macos-latest_3.8	91.41% <ø> (?)
macos-latest_3.9	91.41% <ø> (?)
ubuntu-latest_3.10	91.44% <ø> (?)
ubuntu-latest_3.11	91.44% <ø> (?)
ubuntu-latest_3.9	91.41% <ø> (+<0.01%)	⬆️
windows-latest_3.10	?
windows-latest_3.11	91.38% <ø> (?)
windows-latest_3.8	91.35% <ø> (?)
windows-latest_3.9	91.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ymzayek]

@Remi-Gau can you try skipping the whole file to see if it's actually coming from there? I think you can just add the path to it to collect_ignore in conftest.py

[Remi-Gau]

@Remi-Gau can you try skipping the whole file to see if it's actually coming from there? I think you can just add the path to it to collect_ignore in conftest.py

Good idea

[Remi-Gau]

OK now will try to only run this file in CI to make speed up the testing

[Remi-Gau]

Seems to be coming from one of the 3 test I silenced.
Will refactor them to see if we can better isolate the problem.

[Remi-Gau]

@ymzayek

I am sort of doubting that this PR actually fixed the issue given that the failures seem to have stopped now from other PRs.

But worst case this PR is some tiny update and refactor of tests and we will open another PR if this problem comes back

[bthirion]

But CI is green for the first time, right ?

[Remi-Gau]

But CI is green for the first time, right ?

yup but also on main but given that the fail was flaky it is hard to tell what is happening and whose "fault" it was
-https://github.com/nilearn/nilearn/actions/runs/5409956560/jobs/9830757289

[ymzayek]

I am sort of doubting that this PR actually fixed the issue given that the failures seem to have stopped now from other PRs.

But worst case this PR is some tiny update and refactor of tests and we will open another PR if this problem comes back

Ok agreed. The changes are good nonetheless