Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix position of plots in relation to code blocks #3788

Merged
merged 2 commits into from Jun 29, 2023

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Jun 28, 2023

Part of #3728.

Fix stuff like this:

1

To become this:

2

@github-actions
Copy link
Contributor

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #3788 (a3f4239) into main (7d91e88) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3788   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         133      133           
  Lines       15557    15557           
  Branches     3229     3229           
=======================================
  Hits        14238    14238           
  Misses        772      772           
  Partials      547      547           
Flag Coverage Δ
macos-latest_3.10 91.44% <ø> (?)
macos-latest_3.11 91.44% <ø> (ø)
macos-latest_3.8 91.40% <ø> (?)
macos-latest_3.9 91.40% <ø> (?)
ubuntu-latest_3.10 91.44% <ø> (?)
ubuntu-latest_3.9 ?
windows-latest_3.10 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ymzayek
Copy link
Member Author

ymzayek commented Jun 28, 2023

All the changed examples are the ones with the rendered thumbnails found here: https://output.circle-artifacts.com/output/job/d0c106ac-119e-4f16-b188-2a70c295791d/artifacts/0/dev/auto_examples/index.html

@bthirion
Copy link
Member

LGTM so far.

@ymzayek
Copy link
Member Author

ymzayek commented Jun 28, 2023

This one's ready. The failures are being dealt with in another PR

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx !

@Remi-Gau
Copy link
Collaborator

Thanks @ymzayek

@Remi-Gau Remi-Gau merged commit a85b023 into nilearn:main Jun 29, 2023
26 of 28 checks passed
@ymzayek ymzayek deleted the code-plot-order branch June 29, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants