Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FMT] apply black nilearn.plotting.display #3790

Merged
merged 7 commits into from Jun 30, 2023

Conversation

Remi-Gau
Copy link
Collaborator

Relates to #2528

Changes proposed in this pull request:

  • update configs to include nilearn/plotting/display
  • apply black

@Remi-Gau Remi-Gau marked this pull request as ready for review June 29, 2023 08:42
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #3790 (8e5005f) into main (ee21258) will not change coverage.
The diff coverage is 87.90%.

@@           Coverage Diff           @@
##             main    #3790   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         133      133           
  Lines       15561    15561           
  Branches     3229     3229           
=======================================
  Hits        14242    14242           
  Misses        772      772           
  Partials      547      547           
Flag Coverage Δ
macos-latest_3.10 91.44% <87.90%> (ø)
macos-latest_3.11 91.44% <87.90%> (ø)
macos-latest_3.8 91.41% <87.90%> (ø)
macos-latest_3.9 91.41% <87.90%> (ø)
ubuntu-latest_3.10 91.44% <87.90%> (ø)
ubuntu-latest_3.11 91.44% <87.90%> (ø)
ubuntu-latest_3.8 91.41% <87.90%> (ø)
ubuntu-latest_3.9 91.41% <87.90%> (ø)
windows-latest_3.10 91.38% <87.90%> (ø)
windows-latest_3.11 91.38% <87.90%> (ø)
windows-latest_3.8 91.35% <87.90%> (ø)
windows-latest_3.9 91.35% <87.90%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nilearn/plotting/displays/_figures.py 78.12% <50.00%> (ø)
nilearn/plotting/displays/_slicers.py 89.45% <86.74%> (ø)
nilearn/plotting/displays/__init__.py 100.00% <100.00%> (ø)
nilearn/plotting/displays/_projectors.py 98.23% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM!

nilearn/plotting/displays/_figures.py Outdated Show resolved Hide resolved
nilearn/plotting/displays/_figures.py Outdated Show resolved Hide resolved
nilearn/plotting/displays/_figures.py Outdated Show resolved Hide resolved
nilearn/plotting/displays/_slicers.py Outdated Show resolved Hide resolved
nilearn/plotting/displays/_slicers.py Outdated Show resolved Hide resolved
self._colorbar_ax = figure.add_axes(lt_wid_top_ht)
if _compare_version(matplotlib.__version__, '>=', "1.6"):
self._colorbar_ax.set_facecolor('w')
if _compare_version(matplotlib.__version__, ">=", "1.6"):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: check where _compare_version is used in codebase referencing package versions we don't support anymore and remove extraneous code

Will open an issue

Remi-Gau and others added 5 commits June 29, 2023 15:54
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

@Remi-Gau Remi-Gau merged commit 186845c into nilearn:main Jun 30, 2023
27 of 28 checks passed
@Remi-Gau Remi-Gau deleted the black_plotting branch June 30, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants