[MAINT] deal with new warnings related to sklearn 1.3 #3801
Conversation
|
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Remi-Gau
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3801 +/- ##
==========================================
- Coverage 91.52% 91.51% -0.01%
==========================================
Files 133 133
Lines 15561 15577 +16
Branches 3229 3234 +5
==========================================
+ Hits 14242 14256 +14
- Misses 772 774 +2
Partials 547 547
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| .fit(stimuli.reshape(-1, 100)[train], fmri_data[train]) | ||
| .predict(stimuli.reshape(-1, 100)[test]) | ||
| ) | ||
| predictions = estimator.fit( |
There was a problem hiding this comment.
estimator is defined above but was not used in this file
There was a problem hiding this comment.
If relevant, we can probably also make the changes to unit tests in this PR. For example the warning for the dual default shows up in nilearn/decoding/tests/test_searchlight.py, see https://github.com/nilearn/nilearn/actions/runs/5454471723/jobs/9924639057?pr=3801#step:8:5327
|
|
||
| if self.verbose: | ||
| print("[DictLearning] Learning dictionary") | ||
| # TODO: turn n_iter to max_iter when dropping python 3.7 |
There was a problem hiding this comment.
probably worth opening an issue to track some of the things we may want to check when dropping python 3.7
There was a problem hiding this comment.
It doesn't hurt, but we can also open a new milestone for release 0.11 and document there because that will be when we drop 3.7
|
thanks for the review @ymzayek |
Relates to #3800
Changes proposed in this pull request:
silence some warnings in doc build: