Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] prevent extra line with spaces at the end of names.rst #3809

Merged
merged 2 commits into from Jul 5, 2023

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Jul 4, 2023

Supersedes #3806

Changes proposed in this pull request:

  • update script that generates names.rst to prevent "tug of war" with pre-commit

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@Remi-Gau Remi-Gau marked this pull request as ready for review July 4, 2023 22:17
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #3809 (f59c19d) into main (90dd16e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3809   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files         133      133           
  Lines       15575    15575           
  Branches     3233     3233           
=======================================
  Hits        14256    14256           
  Misses        772      772           
  Partials      547      547           
Flag Coverage Δ
macos-latest_3.10 91.45% <ø> (ø)
macos-latest_3.11 91.45% <ø> (ø)
macos-latest_3.8 91.41% <ø> (ø)
macos-latest_3.9 91.41% <ø> (ø)
ubuntu-latest_3.10 91.45% <ø> (ø)
ubuntu-latest_3.11 91.45% <ø> (ø)
ubuntu-latest_3.8 91.41% <ø> (ø)
ubuntu-latest_3.9 91.41% <ø> (ø)
windows-latest_3.10 91.39% <ø> (ø)
windows-latest_3.11 91.39% <ø> (ø)
windows-latest_3.8 91.36% <ø> (ø)
windows-latest_3.9 91.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Jul 5, 2023

thanks @bthirion

@Remi-Gau Remi-Gau merged commit 36b4725 into nilearn:main Jul 5, 2023
29 checks passed
@Remi-Gau Remi-Gau deleted the fix_bot branch July 5, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants