New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] refactor second-level tests #3814
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #3814 +/- ##
==========================================
+ Coverage 91.53% 91.54% +0.01%
==========================================
Files 133 133
Lines 15575 15629 +54
Branches 3233 3250 +17
==========================================
+ Hits 14256 14307 +51
- Misses 772 774 +2
- Partials 547 548 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but needs a bit of black ;-)
Co-authored-by: bthirion <bertrand.thirion@inria.fr>
if you give me a ✅ I will black the 💩 out of this file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx !
Refactor test before addressing #3807
Changes proposed in this pull request: