Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] move validation of citation.cff in doc build workflow #3823

Merged
merged 1 commit into from Jul 8, 2023

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Jul 7, 2023

Closes #3822

Changes proposed in this pull request:

  • move content of citation.cff validation in the doc build workflow
  • only run doc build if citation file is valid

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #3823 (442c5f3) into main (bce754b) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3823      +/-   ##
==========================================
- Coverage   91.53%   91.51%   -0.02%     
==========================================
  Files         133      133              
  Lines       15601    15599       -2     
  Branches     3247     2984     -263     
==========================================
- Hits        14280    14276       -4     
  Misses        774      774              
- Partials      547      549       +2     
Flag Coverage Δ
macos-latest_3.10 ?
macos-latest_3.11 ?
macos-latest_3.8 ?
macos-latest_3.9 ?
ubuntu-latest_3.10 ?
ubuntu-latest_3.8 91.42% <ø> (ø)
windows-latest_3.10 ?
windows-latest_3.11 ?
windows-latest_3.8 ?
windows-latest_3.9 91.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Remi-Gau Remi-Gau changed the title [INFRA] move validation in doc buuld [INFRA] move validation in doc build Jul 7, 2023
@Remi-Gau Remi-Gau changed the title [INFRA] move validation in doc build [INFRA] move validation of citation.cff in doc build workflow Jul 7, 2023
@Remi-Gau Remi-Gau marked this pull request as ready for review July 7, 2023 17:34
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

@Remi-Gau Remi-Gau merged commit d2dc791 into nilearn:main Jul 8, 2023
29 checks passed
@Remi-Gau Remi-Gau deleted the ci/3822 branch July 8, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate citation.cff validation workflow to doc build workflow
2 participants