New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FMT] apply black to plotting - part 3 #3827
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
raise ImportError( | ||
"A scipy version of at least 1.0 is needed for " | ||
"ordering the matrix with optimal_leaf_ordering." | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we only support "scipy>=1.6.0" so maybe this is not needed anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx.
Codecov Report
@@ Coverage Diff @@
## main #3827 +/- ##
=======================================
Coverage 91.53% 91.54%
=======================================
Files 133 133
Lines 15601 15619 +18
Branches 3247 3248 +1
=======================================
+ Hits 14280 14298 +18
Misses 774 774
Partials 547 547
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Relates to #2528
Changes proposed in this pull request: