New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] update gitblame ignore and contributing #3842
Conversation
I will tackle #3653 after this: will probably ask some people with better gitfu than me at the OHBM hackaton to help me figure out the git blame ignore is not working |
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I also mention the following in this table?
https://nilearn.github.io/stable/development.html#contribution-guidelines
- style your code using black
- sort import
- use f strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure makes sense
Codecov Report
@@ Coverage Diff @@
## main #3842 +/- ##
==========================================
- Coverage 91.57% 91.56% -0.01%
==========================================
Files 133 133
Lines 15619 15645 +26
Branches 3248 3256 +8
==========================================
+ Hits 14303 14326 +23
Misses 770 770
- Partials 546 549 +3
Flags with carried forward coverage won't be shown. Click here to find out more. see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
In my opinion this is the last PR for the formatting automation
and so this closes #2528
Changes proposed in this pull request: